Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how we pass dependencies into components in TriggersActionsUI #78911

Closed
gmmorris opened this issue Sep 30, 2020 · 4 comments
Closed

Improve how we pass dependencies into components in TriggersActionsUI #78911

gmmorris opened this issue Sep 30, 2020 · 4 comments
Labels
Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@gmmorris
Copy link
Contributor

Follow up from #78746

@YulNaumenko suggests we improve how we pass dependencies into components in TriggersActionsUI #78746 (review)

My proposal is to use kibanaReact and useKibana object for adding all common dependancies - this will allow us to remove a lot of repeating code that we path throught the components props. All the plugins have this Kibana context available. I'm not sure how much time it will take for refactoring this, maybe a follow up issue should be created. But we definitely should switch to kibanaReact.

@mikecote
Copy link
Contributor

mikecote commented Oct 2, 2020

Is this a duplicate of #65146?

@mikecote mikecote added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Oct 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@YulNaumenko
Copy link
Contributor

YulNaumenko commented Oct 2, 2020

Yeah, I forgot that I've already opened this issue a long time ago. But it seems to be more critical to fix it now, because our components props number are growing fast and could be replaces with kibanaReact. So we should consider a Higher priority on this issue

@mikecote
Copy link
Contributor

mikecote commented Oct 2, 2020

Thanks @YulNaumenko! I went ahead and added the other issue (#65146) back into triage so it can be discussed at the next triage session. I will close this one as a duplicate 🙏

@mikecote mikecote closed this as completed Oct 2, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

5 participants