Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS build showing X-Pack info? #79859

Closed
afharo opened this issue Oct 7, 2020 · 11 comments · Fixed by #80940
Closed

OSS build showing X-Pack info? #79859

afharo opened this issue Oct 7, 2020 · 11 comments · Fixed by #80940
Assignees
@rylnd @pjhampton @michaelolo24 @stevewritescode
Labels
bug Fixes for quality problems that affect the customer experience Feature:Endpoint Elastic Endpoint feature Feature:Telemetry impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.10.0

Comments

@afharo
Copy link
Member

afharo commented Oct 7, 2020

#78963 added the endpoint security data example flyout to show the telemetry collected for the endpoint security.

image

AFAIK, that is not an OSS feature. Is it?

IMHO, we should not show this if the endpoint security plugin is disabled (or it doesn't exist as in OSS).
@afharo afharo added bug Fixes for quality problems that affect the customer experience Team:Endpoint Management Feature:Endpoint Elastic Endpoint feature v7.10.0 labels Oct 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-management (Team:Endpoint Management)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

@afharo afharo mentioned this issue Oct 7, 2020
Merged
6 tasks
@MindyRS MindyRS added the impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. label Oct 8, 2020
@michaelolo24
Copy link
Contributor

fyi @pjhampton && @stevewritescode?

@pjhampton
Copy link
Contributor

pjhampton commented Oct 11, 2020 •
edited
Loading

Thanks for the ping @michaelolo24 / @afharo - Elastic Security is indeed considered a solution which might not always be available - eg, Non-Elastic ES / Kibana Vendors.
@cosiomoises @paulewing @joe-desimone Do you guys have thoughts here?

Kibana Devs - Can you let me know:

  • If usage data is still collected in OSS versions of the stack?
  • Does Kibana know at runtime what plugins are enabled?

@Bamieh
Copy link
Member

Bamieh commented Oct 12, 2020 •
edited
Loading

@pjhampton

If usage data is still collected in OSS versions of the stack?

Yes we do collect and send telemetry data under OSS versions.

Does Kibana know at runtime what plugins are enabled?

Yes. Platform core provides a way to check enabled plugins. If i recall correctly you can call it in plugin start like this: coreStart.getKibanaFeatures(). Platform team has all their apis documented so it should be easy to find.

@pjhampton
Copy link
Contributor

Ok, thanks for the info, @Bamieh. I will send a patch for this soon.

@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security Solution)

@pjhampton
Copy link
Contributor

pjhampton commented Oct 15, 2020 •
edited
Loading

Dropping an update. @Bamieh is coding something up which we will bridge back to this - turned out it isn't as simple as we hoped as the OSS telemetry plugin needs to know if the security solution is enabled. I'm syncing up with him tomorrow.

@Bamieh Bamieh mentioned this issue Oct 18, 2020
Merged
@MindyRS MindyRS added Team:Defend Workflows “EDR Workflows” sub-team of Security Solution and removed Team:Endpoint Management labels Oct 29, 2020
@muskangulati-qasource
Copy link

muskangulati-qasource commented Nov 25, 2020 •
edited
Loading

Bug Conversion

  • No Test Case Created for this ticket as its Dev Validation Ticket

Thanks!

@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rylnd rylnd

@pjhampton pjhampton

@michaelolo24 michaelolo24

@stevewritescode stevewritescode

Labels
bug Fixes for quality problems that affect the customer experience Feature:Endpoint Elastic Endpoint feature Feature:Telemetry impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Defend Workflows “EDR Workflows” sub-team of Security Solution Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v7.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Telemetry] Add method to enable endpoint security data usage example Bamieh/kibana
10 participants
@rylnd @lukeelmers @MindyRS @afharo @Bamieh @pjhampton @elasticmachine @michaelolo24 @stevewritescode @muskangulati-qasource