Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Outer labels invisible on nested treemap #83525

Closed
flash1293 opened this issue Nov 17, 2020 · 5 comments · Fixed by #84245
Closed

[Lens] Outer labels invisible on nested treemap #83525

flash1293 opened this issue Nov 17, 2020 · 5 comments · Fixed by #84245
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Kibana version: 7.11

Describe the bug: When configuring a treemap with two group by dimensions, the labels of the outer dimension are not shown in the chart.

Steps to reproduce:

  1. Go to Lens
  2. Switch to treemap
  3. Pull in two string fields
  4. Only inner labels are visible, with empty space reserved for outer labels

Expected behavior:
Should show outer labels as well

Screenshots (if relevant):
What's the meaning of the colors?
Screenshot 2020-11-17 at 10 36 11

@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Nov 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@wylieconlon
Copy link
Contributor

Looks like this was caused by the recent PR here: #83061

@dej611 dej611 self-assigned this Nov 24, 2020
@dej611
Copy link
Contributor

dej611 commented Nov 24, 2020

It seems like a bug on the charts library side: I can reproduce it without the #83061 PR applied or on the elastic-charts side as well. :(

@flash1293
Copy link
Contributor Author

@dej611 Could you open a cross-issue with a reproducible example? I checked the storybook here and it seems like it's still possible to style treemaps correctly, so I guess this is something about the default theme that changed recently.

@dej611
Copy link
Contributor

dej611 commented Nov 24, 2020

The elastic-charts library sets the text color to white when the background color is transparent, which is not "wrong". Perhaps "black" could be a better default value here?

I'm currently trying to articulate what's the desiderata from the Lens prospective: in all their storybook examples the textColor property is set for each layer, with the color dynamically computed only if there isn't enough contrast (textInvertible: true), which is not possible in Lens (I suspect).

More in general I think the theme background should be passed over to the elastic-charts library in Lens to make it compute the best text color to comply.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants