Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data Table] Enhance UX for split table mode #84509

Closed
sulemanof opened this issue Nov 30, 2020 · 9 comments
Closed

[Data Table] Enhance UX for split table mode #84509

sulemanof opened this issue Nov 30, 2020 · 9 comments
Labels
discuss Feature:Data Table Data table visualization feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. needs design Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@sulemanof
Copy link
Contributor

Problem description:
Data table visualization has the Split table mode, which can draw several grids at once depending on values amount you pick to split. This could be useful when you have only 2-3 items to split and resulted tables are not huge.
In other cases, giant overflowing/scrolling in two directions panel will be shown:

scrolled_content

Proposal:
Instead, I suppose it would be more convenient to use tabs or a dropdown with a list of split tables, and draw the only table depending on a value set.
This way would resolve a performance issue we have when a lot of grids should be rendered at once.
My own choice would be a dropdown, since tabs implementation at EUI seems not suitable in case we have more than 5 split table - there would be a lot of tabs horizontally scrolled..

The original request was mention here: #70801 (comment)

@sulemanof sulemanof added discuss Feature:Data Table Data table visualization feature needs design Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Nov 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Kibana-Design)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ryankeairns
Copy link
Contributor

I think the dropdown select makes sense in this case. Should this be an optional display setting? or should it only occur in situations of 3 or more grids? The reason I ask is that users may still want to see multiple at once.

@sulemanof
Copy link
Contributor Author

I think the dropdown select makes sense in this case. Should this be an optional display setting? or should it only occur in situations of 3 or more grids? The reason I ask is that users may still want to see multiple at once.

This is a good point to discuss.
Actually, even 2 or 3 tables could take a lot of space if there are a lot of data to display (e.x. 50 rows per page, 10 columns for each table, where a cell could take up to 300px or even more depending on its content).
So I wouldn't rely on tables amount there.

Making this as an option could be a good way to start FMPOV

@timroes @stratoula @cchaos

@stratoula
Copy link
Contributor

I would suggest having a setting which on its default state draw one table (depending on the dropdown selection) but if the user wants to see all of them could change the setting and render all of them.

@stratoula
Copy link
Contributor

stratoula commented Jul 1, 2021

As we are getting close to 7.16 we need to discuss if we want to address the UI/UX problems of multiple grids. They don't render and resize very well.

For example, this big white gap between two tables looks pretty bad.

image

On the other hand, Lens solves this problem in a much better way:
image

So the question is: Do we want to try to improve it somehow or we can just recommend the users that need the split table functionality to try Lens?

Wdyt @flash1293 @timroes @ghudgins

@flash1293
Copy link
Contributor

@stratoula IMHO we should keep the column split in Lens only - it's relatively complex and I would like to avoid maintaining two versions of it. Can we fix the rendering issues of multiple data grids somehow on the EUI side to make it equivalent to the old table implementation?

@stratoula
Copy link
Contributor

Yes for sure we don't want to also support this. I just wonder if it is also a blocker for potentially removing the old implementation. If yes, we have to raise it for 7.16

@stratoula stratoula added the impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. label Jul 21, 2021
@stratoula
Copy link
Contributor

We don't plan to address this and Lens solves this problem so I am closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Data Table Data table visualization feature impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. needs design Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

5 participants