Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console go-to-line shortcut causes error on firefox with 'escape' #8738

Closed
dakrone opened this issue Oct 18, 2016 · 2 comments
Closed

Console go-to-line shortcut causes error on firefox with 'escape' #8738

dakrone opened this issue Oct 18, 2016 · 2 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@dakrone
Copy link
Member

dakrone commented Oct 18, 2016

Kibana version: 5.0.0-RC1 (though it also occurs in 4.6.1)

Elasticsearch version: 2.4.1 & 5.0.0-RC1

Server OS version: Fedora 24, kernel 4.7.7-200.fc24.x86_64 #1 SMP

Browser version: Firefox 49.0

Browser OS version: Fedora 24, kernel 4.7.7-200.fc24.x86_64 #1 SMP

Original install method (e.g. download page, yum, from source, etc.): Tarball download

Description of the problem including expected versus actual behavior:

Hitting ctrl-l in console pops open a dialog to go to a specific line:

screenshot_2016-10-18_16-06-54

When someone hits escape on this dialog box (to clear it if it was unintended), they are taken to this screen:

screenshot_2016-10-18_16-08-06

With this error:

Error: uncaught exception: unknown (can't convert to string) (:0)
window.onerror@http://127.0.0.1:5601/bundles/commons.bundle.js?v=14361:69:13503

There is another problem here, Ctrl-l is a common browser shortcut for all browsers on Linux, to focus the address bar. To overwrite it with no way of disabling this is unfortunate. See @ycombinator's comment here: #4539 (comment) about unfortunate keyboard shortcuts doing unintended things.

I don't think ctrl-l should be overwritten without a way to turn the shortcut off.

@Bargs Bargs added Feature:Console Dev Tools Console Feature bug Fixes for quality problems that affect the customer experience labels Oct 19, 2016
@cjcenizal cjcenizal added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed :Management DO NOT USE labels Jun 14, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@cjcenizal
Copy link
Contributor

I can't reproduce this bug on master, so I'm going to close this issue. I've opened #48410 to capture the need for disabling the keyboard shortcuts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Console Dev Tools Console Feature Feature:Dev Tools Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

6 participants