Tilemaps always make the appStatus dirty

[w33ble]

Kibana version: 5.0

Elasticsearch version: 5.0

Browser version: Chrome latest

Steps to reproduce:

1. Load a tilemap

Describe the feature:

Tilemaps are always being marked as "dirty" in the appStatus.

This is most evident in Reporting, where using a tilemap in a Dashboard prevents the user from creating a report.

Here's an example where a freshly loading tilemap in Visualize can't be turned into a report:

[epixa]

I'm unable to reproduce this with the latest 5.0.0 build candidate of x-pack and the 5.0 branch of Kibana

[w33ble]

There's definitely an issue with the tilemap, the fact that it worked in the past was just kind of random luck.

I'm pulling down the RC3 builds to see if the issue is as pronounced there. If not, then this isn't a blocker.

[thomasneirynck]

I've been able to generate reports in RC3 (chrome/ubuntu). I can't quite trigger the issue where the reporting pane cannot be brought up.

[w33ble]

Confirmed, this isn't an issue in the actual release, but the fact that it works is really just luck. The center point keeps moving around as the tilemap is resized, it just so happens to end up back where it started at the end.

It still needs to be fixed, and still breaks in 5.x, presumably because of some layout changes. Labeling as P1.

I suspect this is also an issue in 4.6.

[LeeDr]

This is broke in 5.1.1 release candidate.

[tbragin]

Adding a "Sharing" label since this issue affect our ability to produce PDF reports of tilemaps. cc: @kobelb

[epixa]

Since this issue exists in 5.0, I'm removing the blocker label. We really should fix it though.

[thomasneirynck]

@epixa agreed.

[tbragin]

Another screenshot showing how "blinky" the problem is:

I can't reproduce this problem in Dasbhboard, so hopefully it only affects users trying to do a PDF of Tilemaps in Visualize.

[thomasneirynck]

@tanya; do you do anything particular for the blinky problem, like moving the map?

"the blinking" - with the question "Please save ..." - does occur each time there is a small change in the map, e.g. due to a small pan. But it is expected behavior fwiw.

[tbragin]

@thomasneirynck no, not doing anything. Pressed "Reporting" once, and it started blinking.

Chrome Version 54.0.2840.98 (64-bit) on Mac OS El Capitan 10.11.6 (15G31)

[w33ble]

As I mentioned early on, the problem is that the map re-draws itself as the application around it changes, and as part of the redraw, the center point on the map changes. The way the "dirty" check works is by comparing the saved center point and the current center point, so when they go out of whack (which almost always happens when you open the reporting dialog, but sometimes even when you open a saved visualization or dashboard), it becomes dirty and you can't generate a report.

This also explains the bouncing behavior that Tanya is seeing. The center point moves when the Reporting dialog changes, marking the visualization "dirty", and makes that dialog instead show a message saying that changes need to be saved. But, by changing the content of the dialog, the center point changes again and just so happens to land back where it started, and so now the visualization is marked as "clean", and the reporting dialog is enabled again. And this goes back and forth forever...

Also, I've seen this dirty state trigger constantly on both visualize and dashboard, it's really a problem with the center point of the map moving, which can happen any time the map re-renders.

[epixa]

@w33ble Suggestions on a fix for this?

[epixa]

@w33ble This "blinky" problem doesn't seem like something that existed in 5.0... why is this only an issue now?

[w33ble]

Nope, it's something leaflet just does. I looked in to it back when I first reported this and didn't see a way to stop leaflet from acting this way.

As for the blinky thing, it's just random chance. It's basically the same reason that things do appear to work correctly in 4.6. In old versions, if you watch it happen, you'll see that when it first loads, it actually starts off in a dirty state, but something triggered a redraw, which randomly happened to land in the center point that it expected to see, so it became clean again, and everything works. For some reason, this broke in 5.0, probably because of some layout change.

[epixa]

I cannot reproduce this blinky issue. On os x, I've tried on three browsers and had almost the same results each time:

Chrome
On both visualize and dashboard, reporting is working in all situations. Newly saved, freshly refreshed, just opened, etc. all allow reporting generation.

Firefox and Safari
Dashboard works fine in all situations. Newly saved or just opened works fine on visualize. Freshly refreshed visualization flicks from the generate report option to "please save" text, and saving it again makes report generation available again. That's annoying as hell, but I know that's been the behavior of previous versions as well, and it at least has a workaround.

@tbragin Do you have any other guidance for how to reproduce that?

[tbragin]

@epixa I can't reproduce the perpetual blinking in the latest version (5.1.1-rc4) but running a Tilemap report from Visualize is still unusable for me on Chrome Version 55.0.2883.75 (64-bit) on Mac OS El Capitan 10.11.6 (15G31). The report generation button only shows for a split second, even after saving the visualization that was saved previously. Your description suggests you are able to generate reports on freshly saved or open tilemap visualizations, but that is not what I'm seeing. I tried running this in incognito to make sure it wasn't some weird caching issue, and I get the same result. Interestingly, I don't see a problem in Firefox and Safari on my system.

As far as a repro, I'm not sure what to say -- I see this behavior on two separate unrelated datasets in various configurations of timepicker and zoom on Visualize Tilemap, and I don't think I'm doing anything special.

[epixa]

Can you close that notification after saving and before going to reporting? That's just a blind guess, but I'm a chronic notification closer, so I definitely would have closed that after saving, and that's the only thing that I can see that might be different between what you're doing an what I'm doing.

[LeeDr]

I can't reproduce the problem on Master (6.0.0-alpha1) as of today. I printed Tile Maps (using Chrome, Firefox, IE 11, and Edge on Windows 10) from Visualizations and with 5 of them on one dashboard, with auto-refresh turned on.
If I do pan a tile map, then I get the "you must save" message as expected.

I think we can close this if we can't reproduce it on the latest 5.2.0 or master.

[marius-dr]

I think this PR changed the behavior in this case:
#9087
There is no "overwrite" confirmation now. Only time I get a refresh of the tilemap is when I save it as a new one.
Tested on Chrome and Firefox, on 5.2.0.