Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SECURITY SOLUTIONS] [Case everywhere] Move Insert Timeline functionality to Cases #94697

Closed
stephmilovic opened this issue Mar 16, 2021 · 4 comments
Labels
Feature:Cases Cases feature Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete

Comments

@stephmilovic
Copy link
Contributor

Move (or pass as arg) the insert_timeline functionality from Security Solution to Cases

@stephmilovic stephmilovic added Team:Threat Hunting Security Solution Threat Hunting Team Feature:Cases Cases feature Theme: rac label obsolete Feature:Cases-RAC-UI labels Mar 16, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting (Team:Threat Hunting)

@patrykkopycinski
Copy link
Contributor

maybe we could expose an API to register custom markdown editor plugins, so that way we could keep functionality related to the timeline inside the security solution and also allow to register custom plugins from other solutions in the future?

@cnasikas
Copy link
Member

cnasikas commented Mar 17, 2021

@patrykkopycinski I agree, it would be nice to have that functionality. A problem that could occur with that approach is the support and maintenance of each markdown plugin. Who gonna own the markdown plugin? Cases or the solution that created? Also it gets a bit more complex when you take into account how is gonna being shown in external services as Jira or ServiceNow. An alternative would be to not expose an API but to review PRs from others when they want to create their markdown plugin and put it in our codebase.

@michaelolo24
Copy link
Contributor

Just noting this conversation continued on over on the PR #96496, and have made the move to just pass the timeline specific functionality through for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Cases Cases feature Team:Threat Hunting Security Solution Threat Hunting Team Theme: rac label obsolete
Projects
None yet
Development

No branches or pull requests

5 participants