[File data visualizer] Embed component into Add Data page in home plugin

[jgowdyelastic]

Recent work has moved ML's File Data Visualizer into it's own plugin.
The File Data Visualizer component is now being imported into the ML app and embedded into the location it originally lived.

The ability to upload data would be better suited in the home plugin's Add Data page.
When adding a new tab to the home app here to contain the File Data Visualizer component, it all works correctly, however errors in the code inform us that we cannot import code from x-pack into the home plugin.

A possible solution could be for the home plugin to allow us to register a tab for the Add data page, but this would require a lot more work than just importing the code.

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[stacey-gammon]

@spalger - I'm trying to find a recent issue, that I think we closed, because you should be able to import from xpack, there was just a wrong eslint error or something. Does this sound familiar to you? I'll keep looking too...

[spalger]

I'm pretty confident that we still require that x-pack code always reach out to OSS code, and not the other way around. I'm not sure which issue you're referring to, doesn't sound familiar, but I'm pretty sure that writing an import from src/plugins to x-pack is going to cause issues that we haven't quite moved past, even though we're not distributing a version of Kibana that only includes SSPL code anymore... not certain though.

[stacey-gammon]

I talked with @jgowdyelastic about this offline and suggested to either make the Add Data page extensible, or to move the file uploader into the home plugin itself. It sounds like the latter option was discussed but difficult due to circular dependency issues which are more and more becoming a problem

We considered this, but it came with other issues as the file_data_visualizer plugin relies on the file_upload plugin to perform some of its tasks. we had to split them because of circular dependencies with maps .
maps uses the file_upload plugin and file_data_visualizer uses embeddable maps

@jgowdyelastic - have you talked to the @elastic/kibana-core team about making the home page extensible with new tabs? This may solve the problem without introducing a dependency on maps into the home page.

[pgayvallet]

A possible solution could be for the home plugin to allow us to register a tab for the Add data page, but this would require a lot more work than just importing the code.

I agree that this sounds like more work, however it's probably the correct approach. To be honest I thought it was already the case.

It would also allow to cleanup the tutorial directory code, to remove the hardcoded stuff for the add data tab...

kibana/src/plugins/home/public/application/components/tutorial_directory.js

Lines 193 to 195 in 4584a8b

	if (this.state.selectedTabId === SAMPLE_DATA_TAB_ID) {
	return <SampleDataSetCards addBasePath={this.props.addBasePath} />;
	}