[AO] Fix issue with alert summary widget refresh on the Alerts page #160159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryam-saeidi
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
Pinging @elastic/actionable-observability (Team: Actionable Observability) |
CoenWarmer
reviewed
Jun 21, 2023
| @@ -106,7 +106,8 @@ function InternalAlertsPage() { | |||
| bucketSize?.intervalString || DEFAULT_INTERVAL, | |||
| bucketSize?.dateFormat || DEFAULT_DATE_FORMAT | |||
| ), | |||
| [alertSearchBarStateProps.rangeFrom, alertSearchBarStateProps.rangeTo, bucketSize] | |||
| // eslint-disable-next-line react-hooks/exhaustive-deps | |||
There was a problem hiding this comment.
Suggestion: if you take in esQuery into the getAlertSummaryTimeRange function, ESLint won't complain about the unnecessary dependency
There was a problem hiding this comment.
What do you mean by moving esQuery into the getAlertSummaryTimeRange function?
There was a problem hiding this comment.
I will merge my PR, but if you share with me details of your suggestion, I can cover it in my future PRs
CoenWarmer
approved these changes
Jun 21, 2023
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
maryam-saeidi
added
the
backport:prev-minor
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 22, 2023
…lastic#160159) Fixes elastic#157245 ## Summary This PR updates the absolute time range when the refresh button is clicked. ## 🧪 How to test - On the Alerts page, click on refresh and check the time range of `_alert_summary` API call, it should be updated with each refresh  (cherry picked from commit 7f906bd)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Jun 22, 2023
…page (#160159) (#160233) # Backport This will backport the following commits from `main` to `8.8`: - [[AO] Fix issue with alert summary widget refresh on the Alerts page (#160159)](#160159) <!--- Backport version: 8.9.7 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Maryam Saeidi","email":"maryam.saeidi@elastic.co"},"sourceCommit":{"committedDate":"2023-06-22T08:36:41Z","message":"[AO] Fix issue with alert summary widget refresh on the Alerts page (#160159)\n\nFixes #157245\r\n\r\n## Summary\r\n\r\nThis PR updates the absolute time range when the refresh button is\r\nclicked.\r\n\r\n## 🧪 How to test\r\n- On the Alerts page, click on refresh and check the time range of\r\n`_alert_summary` API call, it should be updated with each refresh\r\n\r\n\r\n","sha":"7f906bd0c1bddba64e23fdcdfeb61304542fa9c8","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team: Actionable Observability","backport:prev-minor","v8.9.0"],"number":160159,"url":"https://github.com/elastic/kibana/pull/160159","mergeCommit":{"message":"[AO] Fix issue with alert summary widget refresh on the Alerts page (#160159)\n\nFixes #157245\r\n\r\n## Summary\r\n\r\nThis PR updates the absolute time range when the refresh button is\r\nclicked.\r\n\r\n## 🧪 How to test\r\n- On the Alerts page, click on refresh and check the time range of\r\n`_alert_summary` API call, it should be updated with each refresh\r\n\r\n\r\n","sha":"7f906bd0c1bddba64e23fdcdfeb61304542fa9c8"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/160159","number":160159,"mergeCommit":{"message":"[AO] Fix issue with alert summary widget refresh on the Alerts page (#160159)\n\nFixes #157245\r\n\r\n## Summary\r\n\r\nThis PR updates the absolute time range when the refresh button is\r\nclicked.\r\n\r\n## 🧪 How to test\r\n- On the Alerts page, click on refresh and check the time range of\r\n`_alert_summary` API call, it should be updated with each refresh\r\n\r\n\r\n","sha":"7f906bd0c1bddba64e23fdcdfeb61304542fa9c8"}}]}] BACKPORT--> Co-authored-by: Maryam Saeidi <maryam.saeidi@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #157245
Summary
This PR updates the absolute time range when the refresh button is clicked.
🧪 How to test
_alert_summaryAPI call, it should be updated with each refresh