[APM] Change services sparkline condition to align with dependencies table #176293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
jennypavlova
commented
Feb 6, 2024
| @@ -193,7 +193,6 @@ export function MobileServiceOverview() { | |||
| kuery={kueryWithMobileFilters} | |||
| environment={environment} | |||
| fixedHeight={true} | |||
| isSingleColumn={isSingleColumn} | |||
There was a problem hiding this comment.
isSingleColumn in this case is equal to isLarge so I removed the extra prop and used isLarge directly from the hook
jennypavlova
added
release_note:fix
backport:skip
…dressing-inconsistencies-on-service-overview-page-
|
/ci |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
…consistencies-on-service-overview-page-' of https://github.com/jennypavlova/kibana into 175130-apm-enhancing-sparkline-visibility-addressing-inconsistencies-on-service-overview-page-
…dressing-inconsistencies-on-service-overview-page-
…ons table decide when to show sparkline
…dressing-inconsistencies-on-service-overview-page-
…dressing-inconsistencies-on-service-overview-page-
cauemarcondes
approved these changes
Feb 7, 2024
| start={start} | ||
| end={end} | ||
| showPerPageOptions={false} | ||
| numberOfTransactionsPerPage={5} | ||
| shouldShowSparkPlotsProp={!isSingleColumn} |
There was a problem hiding this comment.
Nit: It's up to you if you want to rename it or not. 😁
Suggested change
| shouldShowSparkPlotsProp={!isSingleColumn} | |
| showSparkPlots={!isSingleColumn} |
x-pack/plugins/apm/public/components/shared/dependencies_table/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/apm/public/components/shared/transactions_table/index.tsx
Outdated
Show resolved
Hide resolved
…dressing-inconsistencies-on-service-overview-page-
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
jennypavlova
deleted the
175130-apm-enhancing-sparkline-visibility-addressing-inconsistencies-on-service-overview-page-
branch
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Feb 8, 2024
…table (elastic#176293) Closes elastic#175130 ## Summary This PR changes the condition to show the sparkline in the transaction table to check for `isLarge` size first to be consistent with the dependencies table. Big screen size: <img width="1919" alt="image" src="https://github.com/elastic/kibana/assets/14139027/2b232838-2f25-4319-95a9-9b962d0221ac"> Small screen size:  ## Testing - Compare the dependencies table and the transaction table on the overview tab and check other tabs for the same behavior (big and small screen sizes). https://github.com/elastic/kibana/assets/14139027/f372bd84-3414-4425-b576-29dd1bedca72
CoenWarmer
pushed a commit
to CoenWarmer/kibana
that referenced
this pull request
Feb 15, 2024
…table (elastic#176293) Closes elastic#175130 ## Summary This PR changes the condition to show the sparkline in the transaction table to check for `isLarge` size first to be consistent with the dependencies table. Big screen size: <img width="1919" alt="image" src="https://github.com/elastic/kibana/assets/14139027/2b232838-2f25-4319-95a9-9b962d0221ac"> Small screen size:  ## Testing - Compare the dependencies table and the transaction table on the overview tab and check other tabs for the same behavior (big and small screen sizes). https://github.com/elastic/kibana/assets/14139027/f372bd84-3414-4425-b576-29dd1bedca72
fkanout
pushed a commit
to fkanout/kibana
that referenced
this pull request
Mar 4, 2024
…table (elastic#176293) Closes elastic#175130 ## Summary This PR changes the condition to show the sparkline in the transaction table to check for `isLarge` size first to be consistent with the dependencies table. Big screen size: <img width="1919" alt="image" src="https://github.com/elastic/kibana/assets/14139027/2b232838-2f25-4319-95a9-9b962d0221ac"> Small screen size:  ## Testing - Compare the dependencies table and the transaction table on the overview tab and check other tabs for the same behavior (big and small screen sizes). https://github.com/elastic/kibana/assets/14139027/f372bd84-3414-4425-b576-29dd1bedca72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #175130
Summary
This PR changes the condition to show the sparkline in the transaction table to check for
isLargesize first to be consistent with the dependencies table.Big screen size:
Small screen size:
Testing
Screen.Recording.2024-02-06.at.14.33.17.mov