Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] [Accessibility] Add job ID to select row checkbox aria-label in Jobs List #40149

Merged
merged 3 commits into from
Jul 3, 2019
Merged

[ML] [Accessibility] Add job ID to select row checkbox aria-label in Jobs List #40149

merged 3 commits into from
Jul 3, 2019

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jul 2, 2019 •
edited
Loading

Summary

Adds the job ID to the aria-label of the 'select row' checkbox in the Jobs List.

image

This makes use of the selectableMessage method to construct a proper title and aria-label attributes that was added in elastic/eui#2043

Tested with NVDA screenreader.

Checklist

For maintainers

Fixes #28390

@peteharverson peteharverson requested a review from a team as a code owner July 2, 2019 14:17
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

alvarezmelissa87
alvarezmelissa87 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson mentioned this pull request Jul 2, 2019
Closed
4 tasks
walterra
walterra approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@peteharverson
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson merged commit 7c79427 into elastic:master Jul 3, 2019
@peteharverson peteharverson deleted the ml-jobs-list-select-checkbox branch July 3, 2019 09:37
@peteharverson peteharverson mentioned this pull request Jul 3, 2019
Merged
peteharverson added a commit to peteharverson/kibana that referenced this pull request Jul 3, 2019
@peteharverson
[ML] [Accessibility] Add job ID to select row checkbox aria-label in …
17c1fca 
…Jobs List (elastic#40149)

* [ML] [Accessibility] Add job ID to select row checkbox in Jobs List

* [ML] Add job ID to cannot select checkbox message in Jobs List row

* [ML] Update translations files for select job checkbox
peteharverson added a commit that referenced this pull request Jul 3, 2019
@peteharverson
[ML] [Accessibility] Add job ID to select row checkbox aria-label in …
ae6ed3d 
…Jobs List (#40149) (#40241)

* [ML] [Accessibility] Add job ID to select row checkbox in Jobs List

* [ML] Add job ID to cannot select checkbox message in Jobs List row

* [ML] Update translations files for select job checkbox
@aphelionz aphelionz mentioned this pull request Jul 3, 2019
Closed
12 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
Feature:Anomaly Detection ML anomaly detection :ml Project:Accessibility release_note:enhancement review v7.3.0 v8.0.0 WCAG A
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] [Accessibility] "Select this row" checkbox should also read ID or description
5 participants
@peteharverson @elasticmachine @walterra @alvarezmelissa87 @jgowdyelastic