Remove I prefix in UiActions types #56898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stacey-gammon
force-pushed
the
2020-02-05-remove-i-prefix
branch
from
25b477d to
218a519
Compare
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
stacey-gammon
added
chore
release_note:skip
stacey-gammon
force-pushed
the
2020-02-05-remove-i-prefix
branch
from
218a519 to
df85026
Compare
stacey-gammon
force-pushed
the
2020-02-05-remove-i-prefix
branch
from
df85026 to
d2d100f
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
approved these changes
Feb 6, 2020
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Feb 6, 2020
stacey-gammon
added a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a time we were considering this being standard practice but we have decided to move away from this, documented here: #51674
Some code clean up.