-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Allow reports to be deleted in Management > Kibana > Reporting #60077
[Reporting] Allow reports to be deleted in Management > Kibana > Reporting #60077
Conversation
3af1f6a
to
dcdb6dd
Compare
fc676e8
to
0f772f8
Compare
0f772f8
to
c1e6e3e
Compare
@@ -147,7 +151,47 @@ export function registerJobInfoRoutes( | |||
const request = makeRequestFacade(legacyRequest); | |||
const { docId } = request.params; | |||
|
|||
let response = await jobResponseHandler( | |||
let response = await downloadResponseHandler( | |||
request.pre.management.jobTypes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this block of code is pretty much duplicated below. I'm not sure if it's worth adding a helper yet, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with dupes, might be refactoring for np later anways
@@ -67,3 +68,34 @@ export function jobResponseHandlerFactory( | |||
}); | |||
}; | |||
} | |||
|
|||
export function deleteJobResponseHandlerFactory( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is essentially duplicated as the downloadJobResponseHanderFactory code, but it uses async/await
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
const { intl, jobsToDelete } = this.props; | ||
|
||
const title = | ||
jobsToDelete.length > 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on multi-delete 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…rting (elastic#60077) * [Reporting] Feature Delete Button in Job Listing * refactor listing buttons * multi-delete * confirm modal * remove unused * fix test * mock the id generator for snapshotting * simplify * add search bar above table * fix types errors
Thank you very much for this feature! |
…> Reporting (#60077) (#60684) * [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (#60077) * [Reporting] Feature Delete Button in Job Listing * refactor listing buttons * multi-delete * confirm modal * remove unused * fix test * mock the id generator for snapshotting * simplify * add search bar above table * fix types errors * fix objecttype for 7.x
…o alerting/tls-warning * 'alerting/tls-warning' of github.com:gmmorris/kibana: (32 commits) [ML] Listing all categorization wizard checks (elastic#60502) [Upgrade Assistant] First iteration of batch reindex docs (elastic#59887) [SIEM] Export timeline (elastic#58368) [SIEM] Add support for actions and throttle in Rules (elastic#59641) Fix ace a11y listener (elastic#60639) Add addInfo toast to core notifications service (elastic#60574) fix test description (elastic#60638) [SIEM] Cypress screenshots upload to google cloud (elastic#60556) [canvas/shareable_runtime] sync sass loaders with kbn/optimizer (elastic#60653) [SIEM] Fixes Modification of ML Rules (elastic#60662) [SIEM] [Case] Bulk status update, add comment avatar, id => title in breadcrumbs (elastic#60410) [Alerting] add functional tests for index threshold alertType (elastic#60597) [Ingest]EMT-248: add post action request handler and resources (elastic#60581) Return incident's url (elastic#60617) [Endpoint] TEST: GET alert details - boundary test for first alert retrieval (elastic#60320) [ML] Transforms: Fix pivot preview table mapping. (elastic#60609) [Endpoint] Log random seed for sample data CLI to console (elastic#60646) Use common event model for determining if event is v0 or v1 (elastic#60667) Disables PR Project Assigner workflow [Reporting] Allow reports to be deleted in Management > Kibana > Reporting (elastic#60077) ...
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/transform/creation_index_pattern·ts.transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg adds the aggregation entriesStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/transform/creation_index_pattern·ts.transform creation_index_pattern batch transform with terms+date_histogram groups and avg agg adds the aggregation entriesStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Summary
Adds delete controls and a search bar to the Reporting listing.
Closes #26725
Release note: Added the ability to search and delete historical reports in Management > Kibana > Reporting.
Testing Note: we were not able to do proper IE11 testing due to current standing IE11 bugs. We'll test this feature with IE11 in early 7.7 builds.
Checklist
Delete any items that are not applicable to this PR.
[ ] Documentation was added for features that require explanation or tutorialsFor maintainers