From bd6ee9a5526f0db7bce3ec63c86f69a2eca6bd0a Mon Sep 17 00:00:00 2001
From: Tiago Costa <tiagoffcc@hotmail.com>
Date: Fri, 10 Apr 2020 18:24:53 +0100
Subject: [PATCH 1/2] chore(NA): reduce siem bundle size using
 babel-plugin-transform-imports for lodash

---
 packages/kbn-babel-preset/package.json      |  3 ++-
 packages/kbn-babel-preset/webpack_preset.js | 19 +++++++++++++++++++
 yarn.lock                                   | 12 ++++++++++--
 3 files changed, 31 insertions(+), 3 deletions(-)

diff --git a/packages/kbn-babel-preset/package.json b/packages/kbn-babel-preset/package.json
index b82c8d0fac897..1a2f6941c2020 100644
--- a/packages/kbn-babel-preset/package.json
+++ b/packages/kbn-babel-preset/package.json
@@ -15,6 +15,7 @@
     "babel-plugin-add-module-exports": "^1.0.2",
     "babel-plugin-filter-imports": "^3.0.0",
     "babel-plugin-styled-components": "^1.10.6",
-    "babel-plugin-transform-define": "^1.3.1"
+    "babel-plugin-transform-define": "^1.3.1",
+    "babel-plugin-transform-imports": "^2.0.0"
   }
 }
diff --git a/packages/kbn-babel-preset/webpack_preset.js b/packages/kbn-babel-preset/webpack_preset.js
index d76a3e9714838..ad59821d5f529 100644
--- a/packages/kbn-babel-preset/webpack_preset.js
+++ b/packages/kbn-babel-preset/webpack_preset.js
@@ -42,5 +42,24 @@ module.exports = () => {
         },
       ],
     ],
+    // NOTE: we can enable this by default for everything as soon as we only have one instance
+    // of lodash across the entire project. For now we are just enabling it for siem
+    // as they are extensively using the lodash v4
+    overrides: [
+      {
+        test: [/x-pack[\/\\]legacy[\/\\]plugins[\/\\]siem[\/\\]public/],
+        plugins: [
+          [
+            require.resolve('babel-plugin-transform-imports'),
+            {
+              'lodash/?(((\\w*)?/?)*)': {
+                transform: 'lodash/${1}/${member}',
+                preventFullImport: true,
+              },
+            },
+          ],
+        ],
+      },
+    ],
   };
 };
diff --git a/yarn.lock b/yarn.lock
index 11abd95498c8d..75b3b7f00f0c8 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -1173,7 +1173,7 @@
     lodash "^4.17.13"
     to-fast-properties "^2.0.0"
 
-"@babel/types@^7.9.5":
+"@babel/types@^7.4", "@babel/types@^7.9.5":
   version "7.9.5"
   resolved "https://registry.yarnpkg.com/@babel/types/-/types-7.9.5.tgz#89231f82915a8a566a703b3b20133f73da6b9444"
   integrity sha512-XjnvNqenk818r5zMaba+sLQjnbda31UfUURv3ei0qPQw4u+j2jMyJ5b11y8ZHYTRSI3NnInQkkkRT4fLqqPdHg==
@@ -7081,6 +7081,14 @@ babel-plugin-transform-define@^1.3.1:
     lodash "^4.17.11"
     traverse "0.6.6"
 
+babel-plugin-transform-imports@^2.0.0:
+  version "2.0.0"
+  resolved "https://registry.yarnpkg.com/babel-plugin-transform-imports/-/babel-plugin-transform-imports-2.0.0.tgz#9e5f49f751a9d34ba8f4bb988c7e48ed2419c6b6"
+  integrity sha512-65ewumYJ85QiXdcB/jmiU0y0jg6eL6CdnDqQAqQ8JMOKh1E52VPG3NJzbVKWcgovUR5GBH8IWpCXQ7I8Q3wjgw==
+  dependencies:
+    "@babel/types" "^7.4"
+    is-valid-path "^0.1.1"
+
 babel-plugin-transform-inline-consecutive-adds@^0.4.3:
   version "0.4.3"
   resolved "https://registry.yarnpkg.com/babel-plugin-transform-inline-consecutive-adds/-/babel-plugin-transform-inline-consecutive-adds-0.4.3.tgz#323d47a3ea63a83a7ac3c811ae8e6941faf2b0d1"
@@ -17418,7 +17426,7 @@ is-valid-glob@^1.0.0:
   resolved "https://registry.yarnpkg.com/is-valid-glob/-/is-valid-glob-1.0.0.tgz#29bf3eff701be2d4d315dbacc39bc39fe8f601aa"
   integrity sha1-Kb8+/3Ab4tTTFdusw5vDn+j2Aao=
 
-is-valid-path@0.1.1:
+is-valid-path@0.1.1, is-valid-path@^0.1.1:
   version "0.1.1"
   resolved "https://registry.yarnpkg.com/is-valid-path/-/is-valid-path-0.1.1.tgz#110f9ff74c37f663e1ec7915eb451f2db93ac9df"
   integrity sha1-EQ+f90w39mPh7HkV60UfLbk6yd8=

From 0f7fd94cbc6915ad7b1e59bb359a9f4a4d24d46e Mon Sep 17 00:00:00 2001
From: Tiago Costa <tiagoffcc@hotmail.com>
Date: Fri, 10 Apr 2020 23:26:32 +0100
Subject: [PATCH 2/2] fix(NA): dont use preventFullImport

---
 packages/kbn-babel-preset/webpack_preset.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/kbn-babel-preset/webpack_preset.js b/packages/kbn-babel-preset/webpack_preset.js
index ad59821d5f529..2c1129f275bfe 100644
--- a/packages/kbn-babel-preset/webpack_preset.js
+++ b/packages/kbn-babel-preset/webpack_preset.js
@@ -54,7 +54,7 @@ module.exports = () => {
             {
               'lodash/?(((\\w*)?/?)*)': {
                 transform: 'lodash/${1}/${member}',
-                preventFullImport: true,
+                preventFullImport: false,
               },
             },
           ],