Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs cleanup for ES 6.0 doctype changes #8606

Closed
acchen97 opened this issue Nov 8, 2017 · 6 comments
Closed

Docs cleanup for ES 6.0 doctype changes #8606

acchen97 opened this issue Nov 8, 2017 · 6 comments
Assignees

Comments

@acchen97
Copy link
Contributor

acchen97 commented Nov 8, 2017

There's a few other doc areas that could warrant a minor cleanup from the doctype changes in ES 6.0. The pages below seem to have "type = log" references in both the LS and/or Filebeat examples. Perhaps we can change this to "doc" instead as its now the default in 6.0 for LS and Beats.

/cc @dedemorton

@dedemorton
Copy link
Contributor

@acchen97 I've fixed the issues that you've identified. See #8603.

However, the Multiple Input and Output section looks OK to me. The first type field in the example is the prospector type. The second type field is a custom field that Filebeat adds to the event.

As you would expect, Filebeat sets the _type field in the metadata document to doc . It's possible I'm not fully understanding how this works, but I think the examples as they are written are OK. Can you check and close this issue if you're satisfied that the topic is correct? Thanks!

@acchen97
Copy link
Contributor Author

@dedemorton your PR LGTM, let's close this out after that's merged. 👍

@acchen97
Copy link
Contributor Author

Resolved with #8603.

@tbragin tbragin reopened this Nov 30, 2017
@tbragin
Copy link

tbragin commented Nov 30, 2017

@acchen97 @andrewvc @dedemorton @jordansissel Looks like we missed one? Just came in via info@:
https://www.elastic.co/guide/en/logstash/current/config-examples.html

From the user:

Hi, Example provided at: https://www.elastic.co/guide/en/logstash/current/config-examples.html does not work with version 6.0.0 due to drastic change you made: https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html Error is: [2017-11-29T13:43:17,055][WARN ][logstash.outputs.elasticsearch] Could not index event to Elasticsearch. {:status=>400, :action=>["index", {:_id=>nil, :_index=>"logstash-2017.11.29", :_type=>"apache_access", :_routing=>nil}, #], :response=>{"index"=>{"_index"=>"logstash-2017.11.29", "_type"=>"apache_access", "_id"=>"Fg4GABHwoG4TihcXsi", "status"=>400, "error"=>{"type"=>"illegal_argument_exception", "reason"=>"Rejecting mapping update to [logstash-2017.11.29] as the final mapping would have more than 1 type: [apache_access, apache_error]"}}}} Would be great to have the same example but that works with 6.0.0 ! Regards LI AR

@tbragin
Copy link

tbragin commented Nov 30, 2017

@tbragin tbragin added the bug label Nov 30, 2017
@acchen97
Copy link
Contributor Author

acchen97 commented Dec 7, 2017

@tbragin the reason this is happening is due to the bug we had in the 6.0.0 release. This will be resolved OOTB in 6.0.1.

After further clarification with @andrewvc, I don't believe this warrants any necessary documentation changes. There is no _type field in LS, so the type fields that are specified here can still be used regardless for conditionals or just simply just being another field.

Closing this issue...

@acchen97 acchen97 closed this as completed Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants