Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return package sorted by pacakge title #647

Closed
ph opened this issue Oct 6, 2020 · 7 comments · Fixed by #739
Closed

Return package sorted by pacakge title #647

ph opened this issue Oct 6, 2020 · 7 comments · Fixed by #739
Labels
Team:Ecosystem Label for the Packages Ecosystem team

Comments

@ph
Copy link

ph commented Oct 6, 2020

Originally created by @mostlyjason on elastic/kibana#74577

Currently, the list of integrations shown in Ingest Manager is not alphabetically sorted. This makes it more difficult to find integrations as the number grows from 39 and higher. You can see in the screenshot below that Big IP comes after the letter C. Also custom logs, is after the letter 'K'. It seems like there some kind of sort, but its not sorted based on the name displayed on the screen.

image

@ph
Copy link
Author

ph commented Oct 6, 2020

@mtojek @ycombinator

@ruflin
Copy link
Contributor

ruflin commented Oct 12, 2020

Currently the packages are sorted by the package name: https://github.com/elastic/package-registry/blob/master/search.go#L172 I think what you are looking for is to sort it by package title?

Example here of the Big IP Package:

  {
    "name": "f5",
    "title": "Big-IP Access Policy Manager",
    "version": "0.1.0",
    "release": "experimental",
    "description": "Big-IP Access Policy Manager Integration",
    "type": "integration",
    "download": "/epr/f5/f5-0.1.0.zip",
    "path": "/package/f5/0.1.0"
  },

@ph ph changed the title Return package sorted by name Return package sorted by pacakge title Oct 21, 2020
@ph
Copy link
Author

ph commented Oct 21, 2020

Yes, exactly package title. I don't see values in using name.

@jlind23
Copy link
Contributor

jlind23 commented Oct 4, 2021

@mtojek is it something still relevant?

@mtojek
Copy link
Contributor

mtojek commented Oct 4, 2021

I suggest to review titles and package names first. In the example you brought:

Package name: f5
Package title: Big-IP Access Policy Manager

Shouldn't it be consistent to have "F5 Big-IP..."? If you're used to package names (e.g. f5), you will look for it at the right place in the alphabet. I understand that it might be misleading if you are browsing packages ordered by titles. Anyway it shouldn't be a complex adjustment in the source code (let me see if I can prepare a quick fix).

@jlind23
Copy link
Contributor

jlind23 commented Oct 4, 2021

I do agree that name and titles should be consistent!

Sorting by title is not a viable option I think. What if I am looking for F5? Should I scroll down until "Big-IP ..."? That's weird also. What do you think?

@mtojek
Copy link
Contributor

mtojek commented Oct 4, 2021

In this particular case (F5) I agree with you, but I'm not convinced in the other case: log vs "Custom logs". That's the reason why we may need to adjust ordering.

@mtojek mtojek added Team:Ecosystem Label for the Packages Ecosystem team and removed Team: Ingest Management labels Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants