Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't forward headers when making requests to package storage #935

Merged
merged 1 commit into from
Dec 12, 2022
Merged

Don't forward headers when making requests to package storage #935

merged 1 commit into from
Dec 12, 2022

Conversation

jsoriano
Copy link
Member

Ensure that whenever we request the content to the package storage, we request the whole file, independently of conditional or range headers.

@jsoriano jsoriano self-assigned this Dec 12, 2022
@jsoriano jsoriano requested a review from a team December 12, 2022 15:36
mrodm
mrodm approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@mrodm mrodm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! 👍
Let's ignore for the moment headers to resume downloads or similar, and just download the whole files (zip, zip.sig, etc.)

@elasticmachine
Copy link

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-12T15:36:12.437+0000

  • Duration: 5 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 244
Skipped 0
Total 244

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@jsoriano jsoriano merged commit a7b1b16 into elastic:main Dec 12, 2022
@jsoriano jsoriano deleted the explicitly-disable-content-range-support branch December 12, 2022 16:17
@jsoriano jsoriano mentioned this pull request Dec 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrodm mrodm mrodm approved these changes

Assignees

@jsoriano jsoriano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoriano @elasticmachine @mrodm