Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Change Proposal] Properly support dynamic template mappings #393

Closed
jsoriano opened this issue Aug 18, 2022 · 0 comments · Fixed by #628
Closed

[Change Proposal] Properly support dynamic template mappings #393

jsoriano opened this issue Aug 18, 2022 · 0 comments · Fixed by #628
Labels
discuss Issue needs discussion Team:Ecosystem Label for the Packages Ecosystem team

Comments

@jsoriano
Copy link
Member

We lacked a proper definition for dynamic template mappings in the package spec, and package developers (and the initial import scripts) assumed to follow the same conventions used in beats. This was not properly supported by the spec or fleet, leading to unexpected mappings (elastic/kibana#129344).

Beats-like behaviour was implemented in Fleet in elastic/kibana#137772, to support the convention currently used.

Additionally, it was assumed that any field with wildcards in its name is also a dynamic template, even if it doesn't have type: object, to avoid issues like elastic/beats#32577, more common in integrations than in beats. This was implemented in fleet in elastic/kibana#137978.

Check that these conventions are properly defined in the package spec, and document them in the descriptions of the involved fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Issue needs discussion Team:Ecosystem Label for the Packages Ecosystem team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant