ec_traffic_filter: Fix rule ordering bug #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where multiple having a traffic filter with a few rules will cause an infinite diff loop by changing the field from a List to a Set. This consistently hashes the list using the same algorithm, which does not happen when the field is of `schema.TypeList`. Adds unit and acceptance tests covering this case. Signed-off-by: Marc Lopez <marc5.12@outlook.com>
Also adds a custom set hashing function for the traffic rules set, using the source and optional description if found as hashing keys. Last, changes the assertions to use `TestCheckTypeSetElemNestedAttrs` in the acceptance tests, asserting the rule values without the position. Signed-off-by: Marc Lopez <marc5.12@outlook.com>
|
The actual test that's touched here passes, there's a lot of noise currently in the acceptance tests with failures bubbling up from the platform due to ES instances failing to start in time: From the Jenkins output: 11:31:03 --- PASS: TestAccDeploymentTrafficFilter_basic (12.63s)From my laptop: make testacc TEST_NAME=TestAccDeploymentTrafficFilter_basic
-> Running terraform acceptance tests...
=== RUN TestAccDeploymentTrafficFilter_basic
=== PAUSE TestAccDeploymentTrafficFilter_basic
=== CONT TestAccDeploymentTrafficFilter_basic
--- PASS: TestAccDeploymentTrafficFilter_basic (17.29s)
PASS
ok github.com/elastic/terraform-provider-ec/ec/acc 17.707s |
karencfv
approved these changes
Jan 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug where multiple having a traffic filter with a few rules will
cause an infinite diff loop by changing the field from a List to a Set.
This consistently hashes the list using the same algorithm, which does
not happen when the field is of
schema.TypeList.Also adds a custom set hashing function for the traffic rules set, using
the source and optional description if found as hashing keys.
Last, changes the assertions to use
TestCheckTypeSetElemNestedAttrsinthe acceptance tests, asserting the rule values without the position.
Related Issues
Closes #203
How Has This Been Tested?
Unit and acceptance tested, also tried with an example locally.
Types of Changes