Being able to remove dedicated master node tier

[kunisen]

Overview

For example, when configuring more than 6 nodes, the dedicated master nodes will be added automatically.
But it's not possible to remove it via TF config.

Possible Implementation

Testing

Context

Your Environment

[jguay]

This issue seems duplicated with #343 - can we close this issue ?

[kunisen]

Thanks @jguay Close it with your comment

[kunisen]

FYI, here's the way to repro the issue:

Info

• Version: tf ec provider 0.5.0

First, create a deployment with the dedicated master node:

# create deployment

terraform {
  required_version = ">= 0.12.29"

  required_providers {
    ec = {
      source  = "elastic/ec"
      version = "0.5.0"
    }
  }
}

provider "ec" {}

resource "ec_deployment" "kuni_tftest" {
  region                 = "ap-northeast-1"
  version                = "7.17.7"
  deployment_template_id = "aws-cpu-optimized-arm" # other arm "aws-general-purpose-arm"
  name                   = "kuni_tftest"

  elasticsearch {
    autoscale = "false"

    topology {
      id            = "hot_content"
      size          = "120g"
      zone_count    = "3"
      size_resource = "memory"
    }

    topology {
      id            = "master"
      size          = "8g"
      zone_count    = "3"
      size_resource = "memory"
    }
  }

  kibana {}

  apm {}

  enterprise_search {}
}

Next, shrink it to a fewer nodes to remove dedicated master node

# dimish deployment
terraform {
  required_version = ">= 0.12.29"

  required_providers {
    ec = {
      source  = "elastic/ec"
      version = "0.5.0"
    }
  }
}

provider "ec" {}

resource "ec_deployment" "kuni_tftest" {
  region                 = "ap-northeast-1"
  version                = "7.17.7"
  deployment_template_id = "aws-cpu-optimized-arm"
  name                   = "kuni_tftest"

  elasticsearch {
    autoscale = "false"

    topology {
      id            = "hot_content"
      size          = "60g"
      zone_count    = "1"
      size_resource = "memory"
    }
  }

  kibana {}

  apm {}

  enterprise_search {}
}

Then the following error will be observed:

ec_deployment.kuni_tftest: Modifying... [id=1d03e500ad81a9550ce7301978f4f48d]
╷
│ Error: failed updating deployment: 1 error occurred:
│ 	* api error: clusters.cluster_invalid_plan: Cluster must contain at least a master topology element and a data topology element. 'master' node type is missing,'master' node type exists in more than one topology element (resources.elasticsearch[0].cluster_topology)
│ 
│ 
│ 
│   with ec_deployment.kuni_tftest,
│   on deployment.tf line 16, in resource "ec_deployment" "kuni_tftest":
│   16: resource "ec_deployment" "kuni_tftest" {