Actually delete keystore items as requested. #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't just update the value on a copy of the keystore item and them do nothing like a boss
webfella
approved these changes
Oct 5, 2022
dimuon
pushed a commit
to dimuon/terraform-provider-ec
that referenced
this pull request
Feb 2, 2023
* Actually delete keystore items as requested. Don't just update the value on a copy of the keystore item and them do nothing like a boss * Lint * Add changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't just update the value on a copy of the keystore item and them do nothing like a boss
Related Issues
Fixes #541
Motivation and Context
It so very really should.
How Has This Been Tested?
Manually, acceptance test.
Types of Changes
Readiness Checklist