Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator for elasticsearch strategy #648

Merged
merged 6 commits into from
May 16, 2023

Conversation

dimuon
Copy link
Contributor

@dimuon dimuon commented May 12, 2023

Description

Related Issues

Fixes #647.

Besides the fix, the PR fixes an issue with generated payload for strategy attribute that prevented the provider from sending correct values for strategy (strategy should be specified as "strategy":{"grow_and_shrink":{}} while it used to be specified as "strategy":{"grow_and_shrink":null}}).

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@dimuon dimuon requested a review from a team as a code owner May 12, 2023 09:21
@dimuon
Copy link
Contributor Author

dimuon commented May 15, 2023

@tobio , can you please have a look again - I changed the implementation a bit.

@dimuon dimuon requested a review from tobio May 16, 2023 11:49
@dimuon dimuon merged commit 3e9cb54 into elastic:master May 16, 2023
@dimuon dimuon deleted the bugfix/647/strategy-wrong-validator branch May 16, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It is not possible to configure elasticserach.strategy in 0.6.0+
2 participants