Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support managing keystore entries during deployment creation and update #674

Merged
merged 11 commits into from
Sep 21, 2023

Conversation

dimuon
Copy link
Contributor

@dimuon dimuon commented Jul 5, 2023

Description

Make use of the modified ECE Deployment API that enables specifying ES keystore contents during Create/Update calls.
It should make it possible to handle ES keystore secrets using deployment resource that got a new attribute (example).

The appropriate API change is implemented in ECE 3.7.0, ESS ms-96.
The new IT test (TestAccDeployment_keystore) is expected to fail until ESS ms-96 release. I tested it against my local env.

Related Issues

Rel: #433

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@dimuon dimuon mentioned this pull request Aug 15, 2023
10 tasks
@dimuon dimuon force-pushed the CP-1630/deployment-keystore-attr branch from 61b0df5 to 8401a67 Compare August 16, 2023 13:07
@dimuon dimuon marked this pull request as ready for review August 16, 2023 13:07
@dimuon dimuon requested review from alaudazzi and a team as code owners August 16, 2023 13:07
@dimuon dimuon requested a review from tobio August 16, 2023 13:10
@dimuon dimuon force-pushed the CP-1630/deployment-keystore-attr branch from 8401a67 to 93593c3 Compare August 16, 2023 13:18
Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some questions to make sure I'm on the same page. I think we can add some comments to the read logic to make this clearer too.

We need to add a changelog entry here.

ec/ecresource/deploymentresource/read.go Outdated Show resolved Hide resolved
ec/ecresource/deploymentresource/read.go Show resolved Hide resolved
@dimuon dimuon merged commit e70d0e4 into elastic:master Sep 21, 2023
1 check passed
@dimuon dimuon deleted the CP-1630/deployment-keystore-attr branch September 22, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants