-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support managing keystore entries during deployment creation and update #674
Merged
dimuon
merged 11 commits into
elastic:master
from
dimuon:CP-1630/deployment-keystore-attr
Sep 21, 2023
Merged
Support managing keystore entries during deployment creation and update #674
dimuon
merged 11 commits into
elastic:master
from
dimuon:CP-1630/deployment-keystore-attr
Sep 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
10 tasks
dimuon
force-pushed
the
CP-1630/deployment-keystore-attr
branch
from
August 16, 2023 13:07
61b0df5
to
8401a67
Compare
dimuon
force-pushed
the
CP-1630/deployment-keystore-attr
branch
from
August 16, 2023 13:18
8401a67
to
93593c3
Compare
tobio
approved these changes
Aug 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some questions to make sure I'm on the same page. I think we can add some comments to the read logic to make this clearer too.
We need to add a changelog entry here.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make use of the modified ECE Deployment API that enables specifying ES keystore contents during Create/Update calls.
It should make it possible to handle ES keystore secrets using deployment resource that got a new attribute (example).
The appropriate API change is implemented in ECE 3.7.0, ESS ms-96.
The new IT test (
TestAccDeployment_keystore
) is expected to fail until ESS ms-96 release. I tested it against my local env.Related Issues
Rel: #433
Motivation and Context
How Has This Been Tested?
Types of Changes
Readiness Checklist