Use state for unknown for computed attributes which won't change during plan application #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng plan application These values may potentially change throughout a deployment lifecycle, but those changes will be picked up during the refresh phase, updating state prior to computing the plan These values, when unset, should be 'known' as they are provided in the API response
dimuon
reviewed
Jul 14, 2023
| @@ -44,6 +44,7 @@ func readElasticsearchConfig(in *models.ElasticsearchConfiguration) (*Elasticsea | |||
| return &ElasticsearchConfig{}, nil | |||
| } | |||
|
|
|||
| config.Plugins = []string{} | |||
There was a problem hiding this comment.
It can lead to the inconsistency error if config is empty. Also it's not needed - append can append to nil.
There was a problem hiding this comment.
I mean if TF configuration doesn't have config.
|
Hopefully should address elastic/terraform-provider-elasticstack#370 |
dimuon
reviewed
Jul 14, 2023
| @@ -44,6 +44,7 @@ func readElasticsearchConfig(in *models.ElasticsearchConfiguration) (*Elasticsea | |||
| return &ElasticsearchConfig{}, nil | |||
| } | |||
|
|
|||
| config.Plugins = []string{} | |||
There was a problem hiding this comment.
Suggested change
| config.Plugins = []string{} |
dimuon
approved these changes
Jul 14, 2023
|
@jamesagarside correct, I've been explicitly testing that issue locally with this change as well. |
|
🥳🥳🥳 |
|
Will need to explicitly set cloud_id to computed on name changes or when kibana is added/removed. |
…deployment resource
gigerdo
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These values may potentially change throughout a deployment lifecycle, but those changes will be picked up during the refresh phase, updating state prior to computing the plan
These values, when unset, should be 'known' as they are provided in the API response
This PR does not result in completely clean plans due to how traffic filters currently work. I'm not sure there's a straightforward solution there, as the traffic_filter_association resource can lead to traffic filters changing during the course of a plan application. Simply using state for unknown on this attribute leads to TF crashing as a result of an unexpected new value after apply.
I need to bump the TF version used in the acceptance tests here too.
Related Issues
Fixes #599
How Has This Been Tested?
Manually, unit tests
Types of Changes
Readiness Checklist