Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on the old SDK #720

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Remove dependency on the old SDK #720

merged 2 commits into from
Oct 3, 2023

Conversation

tobio
Copy link
Member

@tobio tobio commented Oct 1, 2023

The provider was still dependant on the old SDK package. There were two main uses:

  • Acceptance testing, replaced by terraform-plugin-testing
  • HashString, added a consistent internal representation

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@tobio tobio requested a review from dimuon October 1, 2023 03:42
@tobio tobio self-assigned this Oct 1, 2023
@tobio tobio requested a review from a team as a code owner October 1, 2023 03:42
@tobio tobio force-pushed the remove-sdk branch 2 times, most recently from df0e136 to edaf4eb Compare October 2, 2023 00:34
dimuon
dimuon approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tobio tobio merged commit c0dee25 into elastic:master Oct 3, 2023
1 check passed
@tobio tobio deleted the remove-sdk branch October 3, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

Assignees

@tobio tobio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobio @dimuon