Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helper.py Copy operation can introduce bugs #213

Open
CorvusPrudens opened this issue Sep 7, 2021 · 1 comment
Open

helper.py Copy operation can introduce bugs #213

CorvusPrudens opened this issue Sep 7, 2021 · 1 comment

Comments

@CorvusPrudens
Copy link
Contributor

During the copy operation of helper.py, the source code can be opened and modified by the rewrite_replace function. This is not ideal of the project name is, say, QSPI, and a macro is called DSY_QSPI_BSS (the QSPI would be replaced by the new project name). There should probably just be a check that excludes files with .cpp or .h extensions.

Also, line 122 is mistakenly formatted as if it were a C printf.

@stephenhensley
Copy link
Collaborator

Good catch, should be easy to fix.

I'm down with a generic "don't open .h/.c/.s/.cpp" rule. The file name should still be replaced, but none of the contents need be changed. Can't think of a case where that'd be desirable anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants