Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libDaisy submodule capitalization #220

Open
CorvusPrudens opened this issue Sep 9, 2021 · 2 comments
Open

libDaisy submodule capitalization #220

CorvusPrudens opened this issue Sep 9, 2021 · 2 comments

Comments

@CorvusPrudens
Copy link
Contributor

The libDaisy capitalization is inconsistent across the tools in DaisyExamples. The submodule is set to always clone into libdaisy, and some of the helper.py commands create lower case libDaisy references. Since the repo name is libDaisy, it's probably best to get everything aligned with that capitalization.

This was particularly annoying for mac / linux users because the unix cpp configuration for vscode assumed a capital D.

@stephenhensley
Copy link
Collaborator

this should be resolved, but I know people may still run into an issue with previous clones (though at this point, even with wrong spelling it compiles on the mac OS machine I was testing on ... So we'll see I suppose).

I'll leave this open for a bit with this note:

If you get a can't find libDaisy related error -- you can either manually rename the "libdaisy" folder to "libDaisy", or reclone the repo to resolve the issue.

@MrBlueXav
Copy link

Hello, I'm on a linux platform.
It's a problem when using helper.py for creating a new project.
The makefile won't work as it refers to "libdaisy" instead of libDaisy.
Easy to fix, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants