Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pot update in SynthVoice example #294

Open
Chect opened this issue Jul 6, 2023 · 1 comment
Open

Pot update in SynthVoice example #294

Chect opened this issue Jul 6, 2023 · 1 comment

Comments

@Chect
Copy link

Chect commented Jul 6, 2023

Looks like the old pot values are set to the current pot values inside the UpdateLED function (oldk2 = k2;)

The old values should only update if the pot has moved past the hysteresis value. Since you use ConditionalParameter on multiple possible targets (probably should be abstracted out) you may want to just set a 'bPotMoved' flag and use that to determine if the old value should be updated

Probably best to move that inside the UpdateKnobs function as well for clarity

@takumi-ogata
Copy link

Hi Chect!
I'm really sorry for the delay in response.

Yes, this is a great suggestion! You're more than welcome to make those changes and submit a PR.
We would greatly appreciate it. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants