Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable publishing to Snapcraft #4982

Closed
patarapolw opened this issue May 19, 2020 · 7 comments
Closed

Disable publishing to Snapcraft #4982

patarapolw opened this issue May 19, 2020 · 7 comments
Labels

Comments

@patarapolw
Copy link

patarapolw commented May 19, 2020

  • Version: 22.6.0

  • Electron Version: 8.2.5

  • Electron Type (current, beta, nightly): current

  • Target: linux

#3187 (comment)

Failed building both in Docker and Travis due to

Install the review-tools from the Snap Store for enhanced checks before uploading this snap.
You are required to login before continuing.
Enter your Ubuntu One e-mail address and password.
If you do not have an Ubuntu One account, you can create one at https://snapcraft.io/account
Authentication error: Failed to get unbound discharge: Invalid request data
  ⨯ exit status 2
github.com/develar/app-builder/pkg/util.ExecuteAndPipeStdOutAndStdErr
	/Volumes/data/Documents/app-builder/pkg/util/exec.go:23
github.com/develar/app-builder/pkg/package-format/snap.publishToStore
	/Volumes/data/Documents/app-builder/pkg/package-format/snap/snapStore.go:35
github.com/develar/app-builder/pkg/package-format/snap.ConfigurePublishCommand.func1
	/Volumes/data/Documents/app-builder/pkg/package-format/snap/snapStore.go:18
github.com/alecthomas/kingpin.(*actionMixin).applyActions
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/actions.go:28
github.com/alecthomas/kingpin.(*Application).applyActions
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:557
github.com/alecthomas/kingpin.(*Application).execute
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:390
github.com/alecthomas/kingpin.(*Application).Parse
	/Volumes/data/go/pkg/mod/github.com/alecthomas/kingpin@v2.2.6+incompatible/app.go:222
main.main
	/Volumes/data/Documents/app-builder/main.go:90
runtime.main
	/usr/local/Cellar/go/1.14.2_1/libexec/src/runtime/proc.go:203
runtime.goexit
	/usr/local/Cellar/go/1.14.2_1/libexec/src/runtime/asm_amd64.s:1373  
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! e-rep2recall@0.3.1 build: `electron-builder -p always`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the e-rep2recall@0.3.1 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR! A complete log of this run can be found in:
npm ERR!     /home/travis/.npm/_logs/2020-05-13T04_49_27_000Z-debug.log

The package.json is

  "build": {
    "publish": [
      {
        "provider": "github"
      }
    ],
    "files": [
      "server/**/*",
      "web/**/*",
      "app.js"
    ]
  }

I don't have Ubuntu One credentials, nor do I want to create one.

@lidel
Copy link
Contributor

lidel commented Jun 9, 2020

+1: publishing to Snapcraft breaks CI when token expires.

Is there a way to build .snap without pushing it to third party servers?
We'd rather publish manually after each release, than break CI.

Update: we disabled snap publishing in https://github.com/ipfs-shipyard/ipfs-desktop/pull/1547/files by removing credentials from CI and switching to github in the snap-specific provider block and it seems to solve the problem

@itsUnsmart
Copy link

this shit is hella broken

@adam-lynch
Copy link
Contributor

You can also set snap.publish to:

{
  provider: "generic",
  url: "https://anydummyurl.com"
}

@stale
Copy link

stale bot commented Sep 13, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Sep 13, 2020
@patarapolw
Copy link
Author

This is very relevant, especially if you don't own an Ubuntu.

@adam-lynch might be a temporary solution.

@stale
Copy link

stale bot commented Nov 13, 2020

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the backlog label Nov 13, 2020
@stale stale bot closed this as completed Nov 21, 2020
@pietrovismara
Copy link

The supposed "solution" is a hacky workaround. Why is there no clear way to disable Snapcraft? This issue should still be open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants