From 6188f0879a6345adf91f95fe2a6398bc32c26e3d Mon Sep 17 00:00:00 2001 From: christophpre <6893212+christophpre@users.noreply.github.com> Date: Tue, 28 Aug 2018 07:54:41 +0200 Subject: [PATCH] =?UTF-8?q?fix:=20=E2=80=9C=5F=5Fstatic=E2=80=9D=20not=20w?= =?UTF-8?q?ork=20as=20expected=20in=20production=20(#114)=20(#189)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit For the renderer process and in production the __static variable should also point to process.resourcesPath and not to the configurator.projectDir, because /static files are located relative to the packaged electron app. --- .../src/targets/RendererTarget.ts | 2 +- test/out/__snapshots__/test.js.snap | 24 +++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/electron-webpack/src/targets/RendererTarget.ts b/packages/electron-webpack/src/targets/RendererTarget.ts index b746d17..57e1bb7 100644 --- a/packages/electron-webpack/src/targets/RendererTarget.ts +++ b/packages/electron-webpack/src/targets/RendererTarget.ts @@ -117,7 +117,7 @@ export class RendererTarget extends BaseRendererTarget { if (configurator.isProduction) { configurator.plugins.push(new DefinePlugin({ - __static: `"${path.join(configurator.projectDir, "static").replace(/\\/g, "\\\\")}"` + __static: `process.resourcesPath + "/static"` })) } else { diff --git a/test/out/__snapshots__/test.js.snap b/test/out/__snapshots__/test.js.snap index cd49e89..72d87a5 100644 --- a/test/out/__snapshots__/test.js.snap +++ b/test/out/__snapshots__/test.js.snap @@ -11,9 +11,9 @@ exports[`app 1`] = ` Child Asset Size Chunks Chunk Names styles.css 135 bytes 0 [emitted] renderer - renderer.js 1.23 KiB 0 [emitted] renderer + renderer.js 1.22 KiB 0 [emitted] renderer styles.css.map 156 bytes 0 [emitted] renderer - renderer.js.map 1.99 KiB 0 [emitted] renderer + renderer.js.map 2.03 KiB 0 [emitted] renderer index.html 334 bytes [emitted] Entrypoint renderer = styles.css renderer.js styles.css.map renderer.js.map [0] external \\"path\\" 42 bytes {0} [built] @@ -59,9 +59,9 @@ Object {