-
Notifications
You must be signed in to change notification settings - Fork 15.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Confirm/Alert popups break focus #41603
Comments
here is the main code.. |
I can confirm this on Ubuntu, however, I cannot confirm the claim that this has always been this way. The Fiddle works perfectly fine for me with |
I would not be surprised if Windows changed something that broke it for Electron. @Maniiisha-sachdeva are you implying that calling I'll have to try this on Monday. |
I tried calling Also tried these versions:
Seeing that Either way it's reassuring that it's not just me and my code. I'll have to implement a workaround for now. edit: changed emoji for clarity. |
in this when i changed the input type to number then i am able to change the number by its up and down arrow but not able to type in it and as i am switching the tab its started working can i work on it further? |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. If you have any new additional information—in particular, if this is still reproducible in the latest version of Electron or in the beta—please include it with your comment! |
Tried the fiddle with 31.0.1 and 32.0.0-alpha.2 Still broken for me. |
dupe of this, right? #31917 |
Huh, didn't find that before. It's 3 years old too. Lovely. |
hello guys, please use electron version lower than 29. use electron 28.3.3 it will solve you problem. |
Nice try 🕵️♂️💻, end of life was 11 Jun 2024 |
What Prinzhorn said about being EOL. Plus that version also doesn't work. Just tested it to see. Honestly something like what I mentioned here would not only give us an option to solve this issue, but it would add a bunch more as well. |
If you are using Electron with Cordova, we have made a Cordova plugin that fix this issue: https://github.com/cimatti/cordova-electron-dialogs-fix |
I found also this: #19977 |
Preflight Checklist
Electron Version
29.1.4
What operating system are you using?
Windows
Operating System Version
Edition: Windows 10 Home | Version: 22H2 | OS build: 19045.4170 | Experience: Windows Feature Experience Pack 1000.19054.1000.0
What arch are you using?
x64
Last Known Working Electron version
No response
Expected Behavior
Using a popup (alert or confirm) then trying to focus an input element shouldn't cause issues.
Actual Behavior
When the application is launched, there are no problems interacting with an input element.
After clicking on a popup from
confirm
oralert
, trying to focus the window that just caused the popup (namely an input element) will no longer work.Focusing on another window and refocusing the window repairs the issue.
Testcase Gist URL
https://gist.github.com/LqdBcnAtWork/9af23d4faa33e74874cd08ffbc8e4ed6
Additional Information
I've noticed this issue for a while, but didn't catch onto the issue being caused by popups. I thought it was random and was caused by some strange interaction with focus that I was causing on my end. Having diagnosed the problem's cause, creating a Fiddle that could replicate it took seconds.
I mention this because it means the issue has existed for many major versions of Electron. How far back is unknown to me. But it goes at least as far back as version 21. I tried version 12.2.3 for fun with Fiddle and the problem persists.
I believe this is caused by the popup taking focus, but the window doesn't recognise that it gets focus back when the popup is closed. I also think this issue might be on Chromium's end. But I'm unsure since neither Chrome or Edge (the only other Chromium apps I have available to me) use the same kind of popup for
alert
andconfirm
or display this issue.The text was updated successfully, but these errors were encountered: