Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Vista-sized icons are not embedded into the exe correctly by rcedit #912

Closed
2 of 3 tasks
BrightLin opened this issue Nov 28, 2018 · 5 comments
Closed
2 of 3 tasks

Windows Vista-sized icons are not embedded into the exe correctly by rcedit #912

BrightLin opened this issue Nov 28, 2018 · 5 comments
Labels
blocked 🚫 Depends on another issue either in this project or a dependency's project build-target:windows Bundling an Electron app specifically for Windows

Comments

@BrightLin
Copy link

BrightLin commented Nov 28, 2018 •
edited
Loading

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.

Please describe your issue:

### issue: the app icon is dim and sawtooth

Application icon：
image

source ico file:
image
@welcome
Copy link

welcome bot commented Nov 28, 2018

👋 Thanks for opening your first issue here! If you have a question about using Electron Packager, read the support docs. If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. Development and issue triage is community-driven, so please be patient and we will get back to you as soon as we can.

To help make it easier for us to investigate your issue, please follow the contributing guidelines.

@malept malept added the blocked 🚫 Depends on another issue either in this project or a dependency's project label Nov 28, 2018
@malept
Copy link
Member

malept commented Nov 28, 2018

I suspect that this is related to electron/rcedit#79 (Electron Packager delegates Windows icon support to this program).

@malept

This comment has been minimized.

Sign in to view
@allexzander

This comment has been minimized.

Sign in to view
@malept malept added the build-target:windows Bundling an Electron app specifically for Windows label Dec 17, 2018
@malept malept changed the title Application icon dim Windows Vista-sized icons are not embedded into the exe correctly by rcedit Jul 1, 2019
@malept
Copy link
Member

malept commented Jul 1, 2019

Since there's nothing that we can do in Electron Packager itself about this, I'm going to direct people to the rcedit bug I referenced earlier and close this bug.

@malept malept closed this as completed Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked 🚫 Depends on another issue either in this project or a dependency's project build-target:windows Bundling an Electron app specifically for Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@malept @allexzander @BrightLin