Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inno-setup generated installation file was broken after modify version string by rcedit #51

Open
cuixiping opened this issue Aug 12, 2017 · 5 comments

Comments

@cuixiping
Copy link

I use inno-setup to generate installation file and then modify some information by rcedit.
The file size will be reduced to about 100~200KB and cannot work correctly.

@zcbenz
Copy link
Contributor

zcbenz commented Sep 13, 2017

Can you provide an example exe file so we can look into the problem? And can you check whether it is the same bug with the other issues?

@sommcz
Copy link

sommcz commented Jan 8, 2018

Hello, i have similiar problem.

  • I generate uninstaller.exe with NSIS with ExectuionLevel user (very simple installer from tutorial: http://nsis.sourceforge.net/Simple_tutorials)
  • and change execution level with rcedit: rcedit.exe uninstaller.exe --set-requested-execution-level requireAdministrator
  • after that uninstaller elevate (OK)
  • but file looks corruped (BAD)

Probably some NSIS's CRC?
(I already tried remove CRCcheck with /NCRC or CheckCRC off options)

image

pack.zip

On my real installation uninstaller changed size from 188kB to 60kB after rcedit and removed all file version info.

@sommcz
Copy link

sommcz commented Jan 8, 2018

additional info:
It looks like some installer data were being stripped out by the rcedit

image

If i do the same change manually with http://www.angusj.com/resourcehacker, it works OK.

If i use rcedit before adding end-of-file data, it works ok too (http://nsis.sourceforge.net/Using_!packhdr).

@vasanthaganeshk
Copy link

I can confirm that I have the same issue.

@thomasrea0113
Copy link

I am having the same issue with Inno Setup 5.x after changing ProductName and CompanyName

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants