build: fix type errors with newer versions of typescript #323
Conversation
|
|
zackschuster
force-pushed
the
fix-post-tsc4.3-type-errors
branch
2 times, most recently
from
c173f4b to
4298496
Compare
zackschuster
force-pushed
the
fix-post-tsc4.3-type-errors
branch
from
4298496 to
dabdbbd
Compare
|
i have essentially given up trying to make this better and just configured |
|
Please merge the PR! |
| return (this.features ?? {})[opt.toLowerCase()] === undefined; | ||
| return this.features != null && this.features[opt.toLowerCase()] != null; |
There was a problem hiding this comment.
There was a problem hiding this comment.
it took a bit of digging because this file has been renamed more than once.
There was a problem hiding this comment.
the only change i did to that method in that commit was to add nullish coalescing. i'm referring specifically to the comparison to undefined.
There was a problem hiding this comment.
agreed. it's wrong. i also can't find any use of this public method anywhere.
|
heya... so we gonna get this merged? |
|
i need to update the changelog prior to merge, as it is badly out-of-date. we don't have any automation for this task so it takes a bit to manually gather & format the data and i haven't had the space. |
fixes #322