Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avatar component #137

Open
5 of 7 tasks
nadonomy opened this issue Jun 2, 2023 · 3 comments
Open
5 of 7 tasks

Avatar component #137

nadonomy opened this issue Jun 2, 2023 · 3 comments
Assignees
Labels
T-New-Component First implementations of components.

Comments

@nadonomy
Copy link
Contributor

nadonomy commented Jun 2, 2023

Component name

Avatar

Figma link

Design phase

Preview Give feedback

Development phase

Preview Give feedback

Adding a reminder that this work includes reducing the number of avatar sizes across platforms (if it hasn't been done already):

Image

@pixlwave @jmartinesp, message @callumu with any questions


Implementation details

@nadonomy nadonomy added the T-New-Component First implementations of components. label Jun 2, 2023
@nadonomy
Copy link
Contributor Author

nadonomy commented Jun 2, 2023

Initial thoughts on specs/requirements:

  • Fully round for users, squared for spaces
  • Need detailed specs on the default state (i.e. when no image is set)
    • Do we use an initialism? First 1 or 2 characters?
    • Do we use a background fill? How colourful or monotone in the new design language and colour scale? Would it benefit from a light gradient for depth? (We experimented a little in DL2.0)
    • Consider using other users avatars when images aren't set - ref the group chat avatar collages in Google Messages, Messenger & iMessage
  • Include presence (offline/online/away - consider status in the future)
  • Consider the latest trust & safety decoration - I think we're placing locks etc separately but worth sanity checking with @americanrefugee
  • Consider notifications decoration - I think we're placing iconography separately but again worth double checking with Amsha

@pixlwave
Copy link
Member

pixlwave commented Jun 2, 2023

Consider using other users avatars when images aren't set.

For Element X this would be a bit more tricky right now as Sliding Sync doesn't provide us with the room members in the room list. If we wanted it, I would image we could add an extension to include the room heroes in the sync response, although a trade-off on that might be increased sync size slowing the app down a bit.

@janogarcia

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-New-Component First implementations of components.
Projects
None yet
Development

No branches or pull requests

4 participants