Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send the fragment part when requesting UrlPreview data #3640

Open
bmarty opened this issue Jul 6, 2021 · 0 comments
Open

Do not send the fragment part when requesting UrlPreview data #3640

bmarty opened this issue Jul 6, 2021 · 0 comments

Comments

@bmarty
Copy link
Member

bmarty commented Jul 6, 2021

  • Send https://github.com/vector-im/element-android/pull/3448/files#diff-63b96f47c62869ba88e77317ff6a0b31483a6ebee57f5669c8be0c0eefce5c4aR19 in an unencrypted room.
  • Observe that the request https://matrix-client.matrix.org/_matrix/media/r0/preview_url?url=https%3A%2F%2Fgh.neting.cc%2Fvector-im%2Felement-android%2Fpull%2F3448%2Ffiles%23diff-63b96f47c62869ba88e77317ff6a0b31483a6ebee57f5669c8be0c0eefce5c4aR19 is send to the server.

The fragment part #diff-63b96f47c62869ba88e77317ff6a0b31483a6ebee57f5669c8be0c0eefce5c4aR19 should not be send to the server.

But the fragment part should be restored when we render the URL preview in the timeline, because the link has definitely not the same value without the fragment part, and the user wants to see the same page when clicking on the preview and when clicking on the link from the message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant