Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space error talks about "room" instead of "space" #4294

Open
kittykat opened this issue Oct 21, 2021 · 3 comments
Open

Space error talks about "room" instead of "space" #4294

kittykat opened this issue Oct 21, 2021 · 3 comments
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Community-Testing Issues found during the community testing sessions Z-Papercuts Visible. Impactful. Predictable to action.

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 21, 2021 •
edited
Loading

Steps to reproduce

  1. Invite to space
  2. Select a user already in the space, "Invite"
  3. Error talks about user being already in the room

Intended result and actual result

What did you expect?

Error message for space says that user is already in the space

What happened instead?

Error message says user is already in the room

Screenshot_20211021-151629.png

Application version and app store

Element 1.3.4 (RC)

Will you send logs?

No
@kittykat kittykat added T-Defect Something isn't working: bugs, crashes, hangs and other reported problems A-Spaces Spaces, groups, communities S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely Z-Community-Testing Issues found during the community testing sessions labels Oct 21, 2021
@ganfra ganfra mentioned this issue Oct 22, 2021
Closed
@kittykat
Copy link
Contributor Author

@niquewoodhouse what about " is already in here"?

@kittykat kittykat added the Z-Papercuts Visible. Impactful. Predictable to action. label Jan 18, 2022
@clokep
Copy link

clokep commented Aug 31, 2022

MSC3848 will give a specific error code in this situations (M_ALREADY_JOINED) which the client can use to provide a localized error (taking into account whether it is a room or a space).

@niquewoodhouse
Copy link

@niquewoodhouse what about " is already in here"?

Just to reply, even if this issues resolved, it might be most helpful to say

  • John is already a member of "Room name"
  • John has already been invited to "Space name"

and use the name of the item if possible, as I can see from the screenshot, context is missing and it might be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Spaces Spaces, groups, communities O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Community-Testing Issues found during the community testing sessions Z-Papercuts Visible. Impactful. Predictable to action.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittykat @clokep @niquewoodhouse