Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the stable hierarchy endpoint from MSC2946 #4462

Closed
clokep opened this issue Nov 12, 2021 · 4 comments · Fixed by #5443
Closed

Use the stable hierarchy endpoint from MSC2946 #4462

clokep opened this issue Nov 12, 2021 · 4 comments · Fixed by #5443
Assignees
@ericdecanini
Labels
A-Developer-Experience A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Refactoring, enabling or disabling functionality, other engineering tasks

Comments

@clokep
Copy link

clokep commented Nov 12, 2021 •
edited by bmarty
Loading

Description

MSC2946 has completed FCP and Synapse is implementing the stable endpoint (see matrix-org/synapse#11329). It would be nice for Element Android to implement the following so that the unstable endpoints can be deprecated:

  • Start using the stable /_matrix/client/v1/rooms/{roomID}/hierarchy endpoint.
  • Ensure that the room_id is not accessed via the list of children_state (this is nested under the room information and should be unnecesary).

This should most likely be implemented to attempt using the stable endpoint before falling back to the unstable endpoint. Please let me know if you have any questions.
@clokep clokep added the A-Spaces Spaces, groups, communities label Nov 12, 2021
@clokep clokep mentioned this issue Nov 12, 2021
Closed
10 tasks
@bmarty
Copy link
Member

bmarty commented Nov 15, 2021

Matrix SDK2 does not support yet the /v1 API. Is it available in the /r0 path?

@clokep
Copy link
Author

clokep commented Nov 15, 2021

Matrix SDK2 does not support yet the /v1 API. Is it available in the /r0 path?

No, it will not be available at the /r0 path due to the new spec versioning of endpoints.

@ouchadam ouchadam added A-Developer-Experience T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Nov 16, 2021
@clokep clokep mentioned this issue Jan 6, 2022
Closed
@kittykat kittykat added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Jan 21, 2022
@bmarty bmarty assigned bmarty and ericdecanini and unassigned bmarty Feb 24, 2022
@bmarty bmarty changed the title Use the stable hierarcy endpoint from MSC2946 Use the stable hierarchy endpoint from MSC2946 Mar 1, 2022
@bmarty
Copy link
Member

bmarty commented Mar 8, 2022

information about v1 can be found here #4245 (follow the links from there)

Let's discuss this together.

@clokep
Copy link
Author

clokep commented Mar 8, 2022

The other thing to check is if the join_rules field (plural version) is being used instead of the proper join_rule field.

@ericdecanini ericdecanini mentioned this issue Mar 8, 2022
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ericdecanini ericdecanini

Labels
A-Developer-Experience A-Spaces Spaces, groups, communities O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes room hierarchy endpoint to stable element-hq/element-android
5 participants
@kittykat @clokep @ouchadam @bmarty @ericdecanini