Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DM room only on first message #5525

Closed
6 tasks done
giomfo opened this issue Mar 11, 2022 · 4 comments
Closed
6 tasks done

Create DM room only on first message #5525

giomfo opened this issue Mar 11, 2022 · 4 comments
Assignees
Labels
A-Create-Room A-DMs T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements

Comments

@giomfo
Copy link
Member

giomfo commented Mar 11, 2022

User Story

  • As a user sending a DM to someone I do not have an active DM conversation with
  • I want the room to be created only when I first send a message (text, image or voice)
  • So that the recipient receives the invite only when there is a message in the room

Detail

  • The user selects someone (Corey) to DM, the current implementation is :

  • We request first to rename the option "CREATE" with "GO"
  • When the user presses 'GO':
    • if there is already a DM with Corey : open the DM
    • if there isn't DM with Corey, instead of the room being created (and Corey being invited to an empty room), The user sees the following interface with the composer (the room has not been created).

image

  • If the user doesn’t send a message ( = Dismiss modal (close button)) no room is created. The user has to start again.
  • If the user does send a message, then the DM room is created by inviting Corey and the message is sent.

Additional Requests

  • If several contacts have been selected in the picker before clicking on the GO option. The interface is adapted :

image

  • If the user selects at least one email address in the selected contact list, the resulting DM will be unencrypted. We have to hide the following tile in the interface

image

@giomfo
Copy link
Member Author

giomfo commented Jun 17, 2022

@Florian14 we have to apply the same process (create DM only on first message) when the end user decides to start a DM from the room member details screen (by clicking on "Direct message" option), whereas the DM is not existing yet.
image

@gaelledel
Copy link

gaelledel commented Jul 11, 2022

UX Review 11/07/22 : Reviewing the whole flow of Start a Chat

  • More space is needed next to the GO button (on the right) - security padding is mandatory on mobile min 12px
  • Title in the fake room should read " Direct message" in singular
  • We need a loading Screen between the screen when user sends the first message and when the room is created. The sting should read: "We're creating your room" (see [Start DM] Add a spinner when sending the first message #6970)
  • If the invitee has not joined the room yet, we should hide the calling options in the nav. (see [Start DM] Hide the calling options until the invitee joins #6973)
  • When inviting email address only the subsequent screen displays: " Empty Room" Instead of showing the full email address string to the user. This will be managed by Direct Message: Manage encrypted DM in case of invite by email #6912
  • When inviting email addresses + Matrix user, The email string is not recognised in the fake room meaning that: When choosing an email + a matrix ID > Next step shows only the Matrix ID and does not report the email address previously selected. @gaelledel we have to discuss about this point, we don't know what is expected in this use case
  • When an invite is done by email and the person receiving the email creates an account in Element, we are then observing 3 members in the created room: the email address, the new element account, the sender account. This is NOT expected behaviour --> We should only show 2 members, the requester account and the newly created account. (see [Invite by Email] The 3pid invite is still visible after the invitee joined #6974)

@Florian14
Copy link
Contributor

Florian14 commented Sep 14, 2022

UX Review 14/09/22

@giomfo
Copy link
Member Author

giomfo commented Sep 27, 2022

I close this issue, each unchecked points (UX improvements and others) will be delivered later. They are all tracked by dedicated issues

@giomfo giomfo closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Create-Room A-DMs T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

No branches or pull requests

5 participants