Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add keyword mentions as an option to the notif panel #1212

Open
ara4n opened this issue Feb 28, 2017 · 5 comments
Open

add keyword mentions as an option to the notif panel #1212

ara4n opened this issue Feb 28, 2017 · 5 comments
Labels
A-Notif-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-MadLittleMods

Comments

@ara4n
Copy link
Member

ara4n commented Feb 28, 2017


  • keywords in notification panel
@ara4n
Copy link
Member Author

ara4n commented Mar 8, 2017

We also aren't highlighting our userid/displayname notifications as the zeplin design shows.

@grahamperrin
Copy link

👍

It's particularly weird when I glimpse a transient notification (with the Riot window not in front) not long enough to know the room where a word was mentioned.

Sometimes if I'm lucky there'll be a corresponding notification on Android. In these cases I can swipe down and refrain from tapping, the notification allows me to know the word and the room.

@MadLittleMods MadLittleMods added the S-Major Severely degrades major functionality or product features, with no satisfactory workaround label Jun 17, 2021
@SimonBrandner SimonBrandner added O-Occasional Affects or can be seen by some users regularly or most users rarely and removed P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 24, 2021
@MadLittleMods
Copy link

MadLittleMods commented Feb 25, 2023

I think I finally figured out the distinction on how to make this work thanks to the details explained by @clokep in matrix-org/synapse#15140 (comment). Also tested and it does behave this way!

The notification panel only shows highlight notifications.

Confusingly, the On setting in Element will set your push rules as {set_tweak: "highlight", "value": false} and those things won't show up in the notification panel.

In order to make this work, you must set Mentions containing keywords as Noisy which will add {set_tweak: "highlight"} to the push rules.

We now have a workaround but this doesn't take away from the fact that Element notification settings are crazy obtuse. I would expect On to still notify me just without sound bings and be considered a highlight.


Please note that messages in encrypted rooms won't show up at all. This is tracked separately by element-hq/element-web#6874

@MadLittleMods MadLittleMods added the S-Minor Impairs non-critical functionality or suitable workarounds exist label Feb 25, 2023
@t3chguy
Copy link
Member

t3chguy commented Feb 27, 2023

@daniellekirkwood this might need considering as part of GYU as we'll be removing the On/Noisy differentiation so keywords might fall off the notification panel

@daniellekirkwood daniellekirkwood self-assigned this Mar 1, 2023
@t3chguy t3chguy transferred this issue from element-hq/element-web Mar 29, 2023
@daniellekirkwood
Copy link
Contributor

Thanks @t3chguy

We're not going to consider this as a part of the GYU piece of work but we are going to ensure that this notifications panel is in our backlog/roadmap.

As part of the work we're doing relating to Design Systems we'll be moving the access point to this panel and highlighting to users that we recognise it needs improvement. At some point in 2024 we should address the panel holistically and ensure it works for the use cases (ideally including encrypted rooms too)

@daniellekirkwood daniellekirkwood removed their assignment Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notif-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-MadLittleMods
Projects
None yet
Development

No branches or pull requests

7 participants