-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Very old events appear out of order in the live timeline after federation backfill #1491
Comments
element-hq/element-web#897 might be related? |
yes, they sound like duplicates |
... so let's close this one. |
Hrm, I'm not convinced they are dups |
This is getting really nasty with federation glitches recently. It'd almost be better to drop events with ancient timestamps than append them to the live timeline. |
I'd say drop events with ancient timestamps if the surrounding events aren't in the current timeline view, otherwise insert them in the correct place in the timeline. Possible gotcha: a malicious homeserver could forge an event that appears to have been sent in the past. (But maybe that's already possible and they look like older events after a refresh?) |
in terms of UI for when old messages flood in: how about showing up a /!\ status prompt saying |
Put the event at the correct location and add a banner would be better. But as a user I probably don't care about this event. This is instant messaging, I will not react to a message 3 pages back (it's not really about time but the quantity of messages). |
Riot likely does not have events that far back to be able to put it at the correct location |
This is effectively impossible for the client to fix on its own - it will need some sort of spec fix, possibly from Sliding Sync or being able to identify gaps in the timeline. |
Created by @ richvdh:sw1v.org.
when synapse decides to
backfillget_missing_events
events over federation, these end up being sent to clients over/sync
, which leads to very confusing timelines with old messagesThe text was updated successfully, but these errors were encountered: