-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show own location in map views #972
Comments
Open design questions for @gaelledel: Should we use the user’s avatar or the standard blue “my location” dot?
Should the map center on the user’s location or zoom out to show all annotations on the map?
|
|
Thanks for your feedback @GitHubUser96. Could you elaborate on what you mean here? I'm not sure I understand what "other" avatars you are referring to. For reference, this is how it looks currently when sharing your location into a room: If we use that same avatar for the feature described in this issue, that'll make it appear as if you're sharing location into the room even though you're not. |
The interaction specs are the following: Should we use the user’s avatar or the standard blue “my location” dot? If somebody else is sharing their location and I press on the my location button, the map should automatically zoom and centre on my location. In the case of static location when I have not shared my location with others, we should display a simple Location pointer (primary green) See details here Should the map center on the user’s location or zoom out to show all annotations on the map? It should zoom in and centre on the users location. |
Designs
https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=3103%3A64256&t=qQTpP8df6OAAcQO1-0
AC
The map views in the timeline remain unchanged
The expanded map view contains a control to display / center on the user’s own location
The button is hidden when the user is currently sharing their own live location in the same room
The button is always shown for static location shares, even if it was from the current user
Required permission pop-ups are displayed when the button is pressed
The user location is displayed using the map view's default current location annotation (subject to debate with design)
Tapping the button centers the map view on the user’s own location (subject to debate with design)
POC PRs
Tasks
Internal references
myhours: https://app.myhours.com/#/projects/2019405/overview
The text was updated successfully, but these errors were encountered: