Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show own location in map views #972

Closed
2 tasks done
Johennes opened this issue Feb 10, 2023 · 5 comments
Closed
2 tasks done

Show own location in map views #972

Johennes opened this issue Feb 10, 2023 · 5 comments

Comments

@Johennes
Copy link
Contributor

Johennes commented Feb 10, 2023

  • As a user of the current Android and iOS apps
  • I want to see my own location when somebody else share's theirs
  • So that I can know where I am relative to them

Designs

https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=3103%3A64256&t=qQTpP8df6OAAcQO1-0

AC

  • The map views in the timeline remain unchanged

  • The expanded map view contains a control to display / center on the user’s own location

    • On web this is already built into MapLibre’s map view
    • On iOS / Android a custom button is needed
  • The button is hidden when the user is currently sharing their own live location in the same room

  • The button is always shown for static location shares, even if it was from the current user

  • Required permission pop-ups are displayed when the button is pressed

  • The user location is displayed using the map view's default current location annotation (subject to debate with design)

  • Tapping the button centers the map view on the user’s own location (subject to debate with design)

POC PRs

Tasks

Preview Give feedback
  1. A-Location-Sharing T-Enhancement Team: Element X Feature Z-Labs
    flescio
  2. A-Location T-Enhancement Team: Element X Feature
    mnaturel

Internal references

myhours: https://app.myhours.com/#/projects/2019405/overview

@Johennes
Copy link
Contributor Author

Johennes commented Feb 10, 2023

Open design questions for @gaelledel:

Should we use the user’s avatar or the standard blue “my location” dot?

  • The Avatar would be easy to reuse and could look more consistent
  • Using the avatar might make it look as if location is shared into the room (which is not the case)
  • Using the avatar could be confusing on the static location map view when you have shared your own location (you’d have two identical avatars on the map then)

Should the map center on the user’s location or zoom out to show all annotations on the map?

  • For this use case people should normally already be close together. So centering on the current location might be sufficient.
  • Similar buttons in system map apps seem to center on the current location when tapped

@eNkKVS4HxHc9jaq
Copy link

Open design questions for @gaelledel:

Should we use the user’s avatar or the standard blue “my location” dot?

  • The Avatar would be easy to reuse and could look more consistent
  • Using the avatar might make it look as if location is shared into the room (which is not the case)
  • Using the avatar could be confusing on the static location map view when you have shared your own location (you’d have to identical avatars on the map then)

Should the map center on the user’s location or zoom out to show all annotations on the map?

  • For this use case people should normally already be close together. So centering on the current location might be sufficient.
  • Similar buttons in system map apps seem to center on the current location when tapped
  1. Can this feature not take advantage of user avatars other than the room avatar to prevent duplicates?

  2. Should probably center since the same behavior is present in other map apps.

@Johennes
Copy link
Contributor Author

Johennes commented Feb 13, 2023

Can this feature not take advantage of user avatars other than the room avatar to prevent duplicates?

Thanks for your feedback @GitHubUser96. Could you elaborate on what you mean here? I'm not sure I understand what "other" avatars you are referring to.

For reference, this is how it looks currently when sharing your location into a room:

Screenshot 2023-02-13 at 08 29 08

If we use that same avatar for the feature described in this issue, that'll make it appear as if you're sharing location into the room even though you're not.

@gaelledel
Copy link

@Johennes

The interaction specs are the following:

Should we use the user’s avatar or the standard blue “my location” dot?

If somebody else is sharing their location and I press on the my location button, the map should automatically zoom and centre on my location. In the case of static location when I have not shared my location with others, we should display a simple Location pointer (primary green)

See details here
https://www.figma.com/file/uthEK6xuo9hSQRdWvPAre5/Location-Sharing?node-id=3103%3A64256&t=geP4idEkXB9sOo2N-4

Should the map center on the user’s location or zoom out to show all annotations on the map?

It should zoom in and centre on the users location.

@gaelledel
Copy link

Screenshot 2023-02-15 at 15 54 15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants