Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If Riot is open in two tabs, we can end up with a UISI if megolm keys are delayed #11504

Closed
ara4n opened this issue Nov 25, 2019 · 1 comment
Closed

If Riot is open in two tabs, we can end up with a UISI if megolm keys are delayed #11504

ara4n opened this issue Nov 25, 2019 · 1 comment
Labels
A-E2EE T-Defect Team: Crypto X-Needs-Community-Testing

Comments

@ara4n
Copy link
Member

ara4n commented Nov 25, 2019 •
edited by pmaier1
Loading

  • Delph had two Riot tabs open with the same device
  • Erik started a new megolm session to him
  • For some reason, the event came through before the keys did (not enough logging to see why)
  • One tab did a successful keyshare req to get the key
  • The other tab raced with this to also to a keyshare req; it ended up requesting it from itself and getting a response from itself.
  • However, this tab failed to then update the display to decrypt the message, perhaps because of getting confused with self-fulfilling its keyshare request and thinking it didn't need to notify the app about the new inbound session.
  • Subsequently this got fixed (perhaps when switching room & back again).

https://github.com/matrix-org/riot-web-rageshakes/issues/1972 has full details.
@ara4n ara4n added the T-Defect label Nov 25, 2019
@ara4n ara4n mentioned this issue Nov 26, 2019
Merged
@ara4n ara4n changed the title Bad MAC when decrypting erik->delph? If Riot is open in two tabs, we can end up with a UISI if megolm keys are delayed Nov 27, 2019
@uhoreg uhoreg added the A-E2EE label Jan 15, 2020
@richvdh
Copy link
Member

richvdh commented Nov 7, 2023

Fixed by matrix-org/matrix-react-sdk#11425

@richvdh richvdh closed this as completed Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-E2EE T-Defect Team: Crypto X-Needs-Community-Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@kittykat @uhoreg @turt2live @ara4n @richvdh