Open user settings keyboard shortcut don't work on Mac

[Twi1ightSparkle]

Description

In macOS, the default keyboard shortcut to open settings for an application is CMD+ ,
So this overrides Riot Web. I'm guessing this applies to the Mac Desktop app as well?

Steps to reproduce

• Buy a Mac
• Open any browser
• Log in to Riot Web
• Press CMD + ,
• Enjoy the preferences window of your web browser

Logs being sent: no

Version information

For the web app:

• Browser: Firefox 74.0 (64-bit), Chromium 82.0.4083.0 (Developer Build) (64-bit), Safari 13.0.5 (15608.5.11)
• OS: macOS 10.15.3 (19D76)
• URL: riot.im/develop / riot.im/app / somewhere else. Probably all Riot Webs

[Twi1ightSparkle]

CMD + ` too (Toggle the top left menu). This switch between windows of the same app in macOS

[t3chguy]

Enjoy the preferences window of your web browser

Overwriting this in-browser was chosen against. Do other webapps (github, Gmail, etc) overwrite it? It works fine in the electron client.

[t3chguy]

If you look at the Keyboard Shortcuts page, it only lists Cmd + , on the desktop app. Not in browser.

[Twi1ightSparkle]

Overwriting this in-browser was chosen against. Do other webapps (github, Gmail, etc) overwrite it? It works fine in the electron client.

I'm glad it doesn't overwrite, but it should be another key imo

If you look at the Keyboard Shortcuts page, it only lists Cmd + , on the desktop app. Not in browser.

I guess my browser is special then. /app has the same ftr

[t3chguy]

Ah, that is a bug. https://github.com/vector-im/riot-web/blob/3d266cb23746d852445e06d3b4c923bed0ee83f5/src/vector/platform/ElectronPlatform.js#L40-L48 should not be getting executed. Will resolve this today.

[t3chguy]

The above PR removes the not-working Cmd + , from the web app but remains in the electron app as was originally intended.

#12645 covers the ability to change shortcuts

[t3chguy]

Going to close in favour of the more generic #12645 which would be able to do this