Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted messages still appear in the room list message preview #15782

Closed
benbz opened this issue Nov 20, 2020 · 2 comments
Closed

Deleted messages still appear in the room list message preview #15782

benbz opened this issue Nov 20, 2020 · 2 comments
Labels

Comments

@benbz
Copy link
Member

benbz commented Nov 20, 2020

Description

image

Steps to reproduce

  • Have message previews turned on
  • Someone posts message in room and then redacts it
  • Un-redacted message still in room list message preview

This was experienced using Element Desktop, but when opening an Element web session that hadn't been opened for days the message preview for this room was still the un-redacted message.

I would expect either to see Message deleted in the preview or whatever should be in the preview if neither the original message or redaction were ever sent.

Related to # #14872 ?

Version information

  • Platform: Desktop & Web
    For the web app:

  • Browser: FF 83

  • OS: Ubuntu

  • URL: Private 1.7.13

For the desktop app:

  • OS: Ubuntu
  • Version: 1.7.13
@benbz benbz added the T-Defect label Nov 20, 2020
@t3chguy
Copy link
Member

t3chguy commented Nov 20, 2020

This looks like it is the issue you linked completely, as the message you show was likely edited before being redacted, and redactions do not affect all instances of the message.

Testing with a redaction alone it does not happen:

image

@benbz
Copy link
Member Author

benbz commented Nov 20, 2020

I think you're right. Looking the source of the events below, there's m.relates_to -> rel_type: m.replace. I can't reproduce with a simple message -> delete flow.

image.

/me resolves and follows #14872 instead

@benbz benbz closed this as completed Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants