Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoded hashtag in matrix.to URL causes it to open in a new tab instead of in-app #16795

Closed
turt2live opened this issue Mar 26, 2021 · 6 comments · Fixed by matrix-org/matrix-react-sdk#5903

Comments

@turt2live
Copy link
Member

https://matrix.to/#/%23matrix:matrix.org

@Ashray123
Copy link

I would like to work on this issue, please guide me on how to reproduce it? :)

@turt2live
Copy link
Member Author

copy/paste that link into a room and click it - it should navigate you to the room, but it doesn't. https://matrix.to/#/#matrix:matrix.org does though.

@Ashray123
Copy link

Ashray123 commented Mar 28, 2021

@turt2live I think one of the reasons why the link is opening in the new tab could be that the link is pointing in the direction which is not completely found, please check the answers part of this link.

@DantrazTrev
Copy link

Hi @Ashray123 , I think it's something to do with the regex pattern MATRIXTO_URL_PATTERN in linkify-matrix.js that is causing the url to not parse in the TextualBody.js in the href .

@MTRNord
Copy link
Contributor

MTRNord commented Apr 28, 2021

Also note that they are not pillified when the pill format gets sent from other clients with urlencoded urls.

@turt2live
Copy link
Member Author

@MTRNord that sounds like a different issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants