Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

logout takes several seconds to take effect #18030

Closed
ara4n opened this issue Jul 16, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12191
Closed

logout takes several seconds to take effect #18030

ara4n opened this issue Jul 16, 2021 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12191
Labels

Comments

@ara4n
Copy link
Member

ara4n commented Jul 16, 2021

if you click the logout button, you get hurled back into the app for a few seconds before it then suddenly kicks you out

@ara4n
Copy link
Member Author

ara4n commented Nov 7, 2023

this has got so bad that the logout button doesn't seem to do anything; after about 5 minutes a logout dialog pops up; clicking 'okay' then in turn does nothing. i restarted the app, and it sat in a spinner having loaded; the JS console was full of 401s, so this time i tried to hit logout again, and this time it instantly threw me out.

@BillCarsonFr
Copy link
Member

For some reason the react sdk is exporting all keys in order to know if there are megolm keys in storage:

https://github.com/matrix-org/matrix-react-sdk/blob/5983528a8d4e20db46638428984c9f3952ede8f3/src/components/structures/UserMenu.tsx#L262-L267

        if (!cli || !cli.isCryptoEnabled() || !(await cli.exportRoomKeys())?.length) {
            // log out without user prompt if they have no local megolm sessions
            defaultDispatcher.dispatch({ action: "logout" });
        } else {
            Modal.createDialog(LogoutDialog);
        }

This is a particularly bad way to check if there are keys that are not saved in backup...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants