Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ugly outline, also appears when pressing a key other than Tab #19889

Open
Linerly opened this issue Nov 25, 2021 · 5 comments
Open

Ugly outline, also appears when pressing a key other than Tab #19889

Linerly opened this issue Nov 25, 2021 · 5 comments
Labels
A11y A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design

Comments

@Linerly
Copy link
Contributor

Linerly commented Nov 25, 2021

Steps to reproduce

  1. Press a key other than Tab (like Esc, Meta (Windows key), Shift, ...)
  2. See an ugly yellow-white outline
    1

Outcome

What did you expect?

Pressing keys other than Tab shouldn't show the outline, the outline should be like this, which isn't ugly:
2

…or like Discord's:
3

What happened instead?

The outline shows whenever I press a key other than Tab (e.g., when taking a screenshot using the shortcut Meta + Shift + PrtSc)

Operating system

Arch Linux

Application version

Element Nightly version: 2021112401 Olm version: 3.2.3

How did you install the app?

AUR

Homeserver

matrix.org

Will you send logs?

No

@SimonBrandner SimonBrandner added A-Appearance A11y X-Needs-Design O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Nov 25, 2021
@t3chguy
Copy link
Member

t3chguy commented Nov 25, 2021

See an ugly yellow-white outline

This is your browser's (Element Desktop is Electron thus Chromium) accessibility outline ftr, in Firefox it looks very different

@SimonBrandner
Copy link
Contributor

See an ugly yellow-white outline

This is your browser's (Element Desktop is Electron thus Chromium) accessibility outline ftr, in Firefox it looks very different

Yeah, though I believe there is a way to change the look of this since Discord has the blueish one on desktop

@t3chguy
Copy link
Member

t3chguy commented Nov 25, 2021

Yes we can definitely style it, I'm not saying we can't, just explaining what it is better than "ugly outline" - not that it isn't also that

@Penguin-Guru
Copy link

I think The Super/Meta/etc... button is particularly important to disconnect from this functionality. Convention on all platforms (I know of) has long considered this a system utility button, not to be used by applications. Therefore, a lot of common keyboard shortcuts use this button.

For what it's worth, I use Chromium as my normal web browser and this accessibility outline has never appeared when I press these buttons on my keyboard. It may be useful for some people, I don't know, but I definitely think it should disabled by default in the Element desktop client.

@HarHarLinks
Copy link
Contributor

I don't really mind it, but

Convention on all platforms (I know of) has long considered this a system utility button, not to be used by applications. Therefore, a lot of common keyboard shortcuts use this button.

I agree with this, and want to point out that this behaviour might be confusing for users less familiar with the existence of such features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A11y A-Appearance O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Needs-Design
Projects
None yet
Development

No branches or pull requests

5 participants