Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map reloads every time a message is sent in thread #20313

Closed
libexus opened this issue Dec 21, 2021 · 6 comments
Closed

Map reloads every time a message is sent in thread #20313

libexus opened this issue Dec 21, 2021 · 6 comments
Assignees
Labels
A-Location-Sharing A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@libexus
Copy link
Contributor

libexus commented Dec 21, 2021

Steps to reproduce

  1. Share your location into a room
  2. Create a thread from it
  3. Every time you send a new message into the thread, the map reloads

Outcome

What did you expect?

Nothing.

What happened instead?

The map reloads every single time a message is sent

Operating system

Linux (X11)

Browser information

Firefox 95.0.1

URL for webapp

develop.element.io

Application version

Element 211f480

Homeserver

matrix.org

Will you send logs?

No

@germain-gg germain-gg added A-Location-Sharing A-Threads Z-Labs O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist labels Dec 22, 2021
@germain-gg germain-gg changed the title Map reloads every time a message ist sent in thread Map reloads every time a message is sent in thread Dec 22, 2021
@libexus
Copy link
Contributor Author

libexus commented Dec 28, 2021

Now the map doesn't reload anymore but I get an error ("Something went wrong! Please create a new issue on GitHub...")

@andybalaam
Copy link
Member

I've just merged matrix-org/matrix-react-sdk#7568 , which I think is the last bug in this area, so I'd appreciate it @libexus if you could re-test and let me know whether this is fixed. Thanks!

@libexus
Copy link
Contributor Author

libexus commented Jan 19, 2022

@andybalaam It doesn't happen again with the location event I tested this originally

But I didn't manage to test it with a new location event because a) location sharing on my Firefox somehow doesn't work generally and b) sending custom locations is not possible anymore. Don't know if this is a bug or intentional.

@andybalaam
Copy link
Member

Thank you @libexus . I will close this bug.

b) Yes, we have temporarily removed sending custom locations - it will return when we have designed it nicely (the existing UI was just a proof of concept)

a) Hmm. Please could you log a new bug with exactly what you did and exactly what happened? It is probably related to the browser permissions.

@libexus
Copy link
Contributor Author

libexus commented Jan 21, 2022

a) Hmm. Please could you log a new bug with exactly what you did and exactly what happened? It is probably related to the browser permissions.

It doesn't work with any website so it's not element-related

@andybalaam
Copy link
Member

Ah OK, sorry to hear that :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Location-Sharing A-Threads O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

No branches or pull requests

3 participants