"Set a new custom sound" dialog has two buttons for choosing a file

[anoadragon453]

Steps to reproduce

If one:

1. navigates to a room
2. opens up the room settings
3. clicks the Notifications settings tab, they will see the following.

One can use both Choose File or Browse buttons to choose a room-specific notification sound. They seem to do the same thing, but having two different buttons is confusing. A user may wonder if one does something different from the other.

Outcome

What did you expect?

Just a single button. I would personally opt to keep the styled "Browse" button if possible.

What happened instead?

Two buttons?? Analysis paralysis!!

Operating system

Arch Linux

Application version

Element Nightly version: 2022012901, Olm version: 3.2.8

How did you install the app?

https://aur.archlinux.org/packages/element-desktop-nightly-bin/

Homeserver

No response

Will you send logs?

No

[dbkr]

Hiding the native file picker control sounds like the right thing, although it may want something indicating what file is selected once you've picked one. Design - can you confirm?

This could be a great first issue for someone once we confirm what it should look like

[tbertels]

While the Save button works, we have to close and open back the Notifications settings to see the result (the sound file being shown above, under Sounds).
It seems this whole part would need a redesign.

[justledbetter]

In Element 1.11.14, both the native file picker and the Browse button allow us to select a file, but the Save button does not do anything when clicked. The following message streams into the JS console log, but the file itself does not appear to be uploaded or applied to the configuration (linebreaks added for legibility).

rageshake.ts:73 Returning only the content-uri from uploadContent(). Future versions of the 
js-sdk will change this default, to return the whole response object. Set 
opts.onlyContentUri=false to change this behaviour now.

[t3chguy]

@justledbetter that issue is entirely unrelated, and fixed by matrix-org/matrix-react-sdk@77764d8 in tomorrow's release

[justledbetter]

Aha! Thank you so much, sorry for posting to the wrong issue - Didn't see that one.